Closed Bug 1869526 Opened 2 years ago Closed 2 years ago

In cubeb-coreaudio-rs only set up an VoiceProcessingIO AudioUnit when VOICE is preferred for the input stream

Categories

(Core :: Audio/Video: cubeb, task, P2)

task

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
firefox122 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 file)

The VoiceProcessingIO AudioUnit forces both input and output to MONO, regardless of the capabilities of the devices involved. Not having the VoiceProcessingIO AudioUnit makes us susceptible to bug 1670633 for some input/output device pairs.

As a tradeoff, only use VoiceProcessingIO when VOICE is set in the input stream prefs, i.e. for getUserMedia with any audio processing constraint enabled. When all audio processing constraints are false, gecko does not pass in the input stream pref VOICE.

Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/autoland/rev/de61802013d3 Update cubeb-coreaudio-rs to 5fcea74f and cubeb-sys to 0.10.7. r=cubeb-reviewers,supply-chain-reviewers,kinetik
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: