1869605 - Remove the test coverage for the old firefox view implemention

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P2)

Description

[Sam Foster [:sfoster] (he/him)]

We're in the process of removing the old firefox view implementation. Step 1 is to remove the tests that would otherwise fail when we do that.
There are some details in these tests which we'll want to port over to the new version. We'll file separate bugs for those.

Comment 1

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1869605 - Remove all legacy Firefox View related tests. r=sfoster

This patch removes all tests covering the old Firefox View whilst preserving those that cover Next.

A separate bug will be filed for any old tests that have been removed that Next is currently missing
coverage to be added in a future patch.

Ideally this will be landed alongside patches that:

• update the view pref
• update the about redirector
• remove all old Firefox View files and assets

Comment 2

[Phabricator Automation]

Comment on attachment 9368282 [details]
Bug 1869605 - Remove all legacy Firefox View related tests. r=sfoster

Revision D196080 was moved to bug 1850501. Setting attachment 9368282 [details] to obsolete.

Comment 3

[Phabricator Automation]

Comment on attachment 9368282 [details]
Bug 1869605 - Remove all legacy Firefox View related tests. r=sfoster

Revision D196080 was moved to bug 1850501. Setting attachment 9368282 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b2ffe9a4d06
Remove all legacy Firefox View related tests. r=sfoster,fxview-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing bc failures on browser_notification_dot.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7b2ffe9a4d06915dbff48039e7582759ebe66ae2&selectedTaskRun=O5pD1LlMRleD22kKSqjF-w.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=440893933&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/d212aefe4ab7fdabc079fa32865c3693b0da335d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05b09125b90b
Remove all legacy Firefox View related tests. r=sfoster,fxview-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing several browser chrome failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=576e61e3970b803be63455fa2dc84a5eb0642be4&searchStr=bc&selectedTaskRun=RXMyvIzgScGsUN8t6PtelA.0

Failure logs:

• browser_all_files_referenced.js | there should be no unreferenced files - Got 8, expected +0 - https://treeherder.mozilla.org/logviewer?job_id=441174529&repo=autoland
• browser/browser_sma_click_element.js | Uncaught exception in test bound test_CLICK_ELEMENT - undefined - timed out after 50 tries - https://treeherder.mozilla.org/logviewer?job_id=441174375&repo=autoland
• browser_blanking.js | Uncaught exception in test bound - at resource://testing-common/BrowserTestUtils.sys.mjs:260 - TypeError: can't access property "linkedBrowser", tab is null - https://treeherder.mozilla.org/logviewer?job_id=441174459&repo=autoland
• firefoxview-next/browser_firefoxview_next.js | undefined assertion name - Got "about:firefoxview", expected "about:firefoxview-next - https://treeherder.mozilla.org/logviewer?job_id=441177590&repo=autoland
• browser_feature_callout.js | A promise chain failed to handle a rejection: can't access property "template", this.message is null - stack: showFeatureCallout@resource:///modules/FeatureCallout.sys.mjs - https://treeherder.mozilla.org/logviewer?job_id=441173308&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/f01c568edb2688a905c351e7d49676130ca5e354

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7641a328a91c
Remove all legacy Firefox View related tests. r=sfoster,fxview-reviewers

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7641a328a91c