1869653 - Add command to quickly check if vendored Rust dependencies are in sync with upstream

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

In order to prevent hard to diagnose build bustage, Thunderbird sheriffs will need a quick way to verify that vendored Rust libraries are up-to-date with upstream.

This will have two parts:

• Add mach tb-rust subcommand to do the check
• Run this check at build time if --enable-thunderbird-rust is set; abort the build if necessary

The second part should not cause problems for most local development unless using autoland or in-progress mozilla central patches.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1869653 - Checksum upstream inputs to tb-rust vendor. r=ikey

Provides a quick check to see if comm/third_party/rust is in sync with upstream.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1869653 - Generate valid TOML when processing workspace_dependencies. r=ikey

Comment 3

[Rob Lemley [:rjl]]

Attachment: WIP: Bug 1869653 - Ensure that cargo version is new enough for tb-rust vendor.

Depends on D196380

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1869653 - Ensure that cargo version is new enough for tb-rust vendor. r=#thunderbird-build-system-reviewers

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1869653 - Run tb-rust vendor. r=ikey

m-c: 63aeef886ee6

Depends on D196237

Comment 6

[Rob Lemley [:rjl]]

Attachment: Bug 1869653 - Abort build when vendored rust libs are out of sync with upstream. r=#thunderbird-build-system-reviewers

If --enable-thunderbird-rust is set, make sure that vendored libs are in sync
with upstream to avoid non-obvious build failures.

Depends on D196383

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7a7ca68d1ad4
Ensure that cargo version is new enough for tb-rust vendor. r=dandarnell
https://hg.mozilla.org/comm-central/rev/a9c2999de50f
Checksum upstream inputs to tb-rust vendor. r=ikey
https://hg.mozilla.org/comm-central/rev/442105034f47
Run tb-rust vendor. r=ikey
https://hg.mozilla.org/comm-central/rev/eaa486e01499
Abort build when vendored rust libs are out of sync with upstream. r=dandarnell

Comment 8

[Rob Lemley [:rjl]]

Attachment: Bug 1869653 - Fix missing sys import. r=#thunderbird-build-system-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/afe1d7e773e1
Fix missing sys import. r=dandarnell

Comment 10

[Intermittent Failures Robot]

3 failures in 2274 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 3

Platform and build breakdown:

• linux64: 1
  • opt: 1
• osx-cross: 1
  • opt: 1
• windows2012-64: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1869653&startday=2024-01-01&endday=2024-01-07&tree=all