1869659 - Crash in [@ mozilla::layers::CanvasTranslator::SetDataSurfaceBuffer]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P1)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/3cb1d80c-ed62-469b-a38e-3bd6f0231212

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(mHeader->readerState == State::Paused)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::layers::CanvasTranslator::SetDataSurfaceBuffer  gfx/layers/ipc/CanvasTranslator.cpp:234
1  xul.dll  mozilla::detail::RunnableMethodArguments<mozilla::UniquePtr<void*, mozilla::detail::FileHandleDeleter>&&, unsigned long long>::apply<mozilla::layers::CanvasTranslator, void  const  xpcom/threads/nsThreadUtils.h:1213
1  xul.dll  std::invoke  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/type_traits:1534
1  xul.dll  std::_Apply_impl  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/tuple:974
1  xul.dll  std::apply  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/tuple:979
1  xul.dll  mozilla::detail::RunnableMethodArguments<mozilla::UniquePtr<void*, mozilla::detail::FileHandleDeleter>&&, unsigned long long>::apply  xpcom/threads/nsThreadUtils.h:1162
1  xul.dll  mozilla::detail::RunnableMethodImpl<mozilla::layers::CanvasTranslator*, void   xpcom/threads/nsThreadUtils.h:1213
2  xul.dll  nsThread::ProcessNextEvent  xpcom/threads/nsThread.cpp:1193
2  xul.dll  NS_ProcessNextEvent  xpcom/threads/nsThreadUtils.cpp:480
3  xul.dll  mozilla::ipc::MessagePumpForNonMainThreads::Run  ipc/glue/MessagePump.cpp:300

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

I wonder if this could just be on a failure path, e.g.
https://searchfox.org/mozilla-central/rev/da48f565f70a57ac28862090828fbaa7fd8556f6/gfx/layers/ipc/CanvasTranslator.cpp#331

and maybe we just need to include that in the assert?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1863914

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Otherwise we should at least make this a gfxCriticalError where we crash but also record the status value.

Comment 4

[Bob Owen (:bobowen)]

Attachment: Bug 1869659: Check for Failed in CanvasTranslator::AddBuffer and SetDataSurfaceBuffer. r=aosmond!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/770a728fe2b7
Check for Failed in CanvasTranslator::AddBuffer and SetDataSurfaceBuffer. r=aosmond

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/770a728fe2b7