1875656 - Crash in [@ mozilla::layers::CanvasTranslator::AddBuffer]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Andrew Osmond [:aosmond] (he/him)]

Crash report: https://crash-stats.mozilla.org/report/index/5ed22276-fa01-4126-8bfa-328cc0240121

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(mHeader->readerState == State::Paused)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::layers::CanvasTranslator::AddBuffer  gfx/layers/ipc/CanvasTranslator.cpp:234
1  xul.dll  mozilla::detail::RunnableMethodArguments<mozilla::UniquePtr<void*, mozilla::detail::FileHandleDeleter>&&, unsigned long long>::apply<mozilla::layers::CanvasTranslator, void  const  xpcom/threads/nsThreadUtils.h:1213
1  xul.dll  std::invoke  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/type_traits:1534
1  xul.dll  std::_Apply_impl  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/tuple:974
1  xul.dll  std::apply  /builds/worker/fetches/vs/VC/Tools/MSVC/14.29.30133/include/tuple:979
1  xul.dll  mozilla::detail::RunnableMethodArguments<mozilla::UniquePtr<void*, mozilla::detail::FileHandleDeleter>&&, unsigned long long>::apply  xpcom/threads/nsThreadUtils.h:1162
1  xul.dll  mozilla::detail::RunnableMethodImpl<mozilla::layers::CanvasTranslator*, void   xpcom/threads/nsThreadUtils.h:1213
2  xul.dll  mozilla::TaskQueue::Runner::Run  xpcom/threads/TaskQueue.cpp:257
3  xul.dll  nsThreadPool::Run  xpcom/threads/nsThreadPool.cpp:341
4  xul.dll  nsThread::ProcessNextEvent  xpcom/threads/nsThread.cpp:1193

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1875656: Make CanvasTranslator::AddBuffer diagnostic assert instead of release. r=#gfx-reviewers,aosmond

Comment 2

[Bob Owen (:bobowen)]

https://treeherder.mozilla.org/jobs?repo=try&duplicate_jobs=visible&revision=d5bbdb3f79877c3d5677eac518f77a61992ced60

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a553790df1c7
Make CanvasTranslator::AddBuffer diagnostic assert instead of release. r=aosmond,gfx-reviewers

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a553790df1c7

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bobowen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox123 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Bob Owen (:bobowen)]

Comment on attachment 9375766 [details]
Bug 1875656: Make CanvasTranslator::AddBuffer diagnostic assert instead of release. r=#gfx-reviewers,aosmond

Beta/Release Uplift Approval Request

• User impact if declined: Crash will continue in late beta and release. It's a low level crash, but it is often a browser crash for non-windows.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple change of a release assert to a log and diagnostic assert.
• String changes made/needed: None
• Is Android affected?: Yes

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9375766 [details]
Bug 1875656: Make CanvasTranslator::AddBuffer diagnostic assert instead of release. r=#gfx-reviewers,aosmond

Approved for 123 beta 4, thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c4f60b3ed4c5

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/c4f60b3ed4c5