1869735 - Wrong context id for network events of iframe navigation requests

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open a page with an iframe, eg http://janodvarko.cz/tests/fission/case1/index.html
• subscribe to network events for all contexts
• reload or navigate the iframe (either using browsingContext commands, or manually by right clicking on the iframe...)

ER: The network events for the iframe navigation should be associated with the context id of the iframe
AR: The network events are using the parent window context id

Subsequent requests (eg favicon) done in the iframe will have the correct context id, the one from the iframe.

This means we get the wrong navigation id in those requests.

We also have the same issue when dynamically adding an iframe in a page, the initial request to create the iframe will be mapped to the parent's context id, which makes one puppeteer test fail (network Request.frame should work for subframe navigation request).

Comment 1

[Julian Descottes [:jdescottes]]

Hi Valentin,

See description above for more details, tldr channels created for an iframe navigation always seem "owned" by the iframe's parent context.

At the moment we are retrieving the BrowsingContext corresponding to a channel via channel.loadInfo.browsingContextID, and we are doing this when receiving the activity ACTIVITY_SUBTYPE_REQUEST_HEADER. I've also tried to look at the loadContext's associatedWindow or topFrameElement, but they are always set to the frame's parent.

Do you know if there is a way to link those channels to the BrowsingContext of the iframe being loaded/navigated?

Comment 2

[Julian Descottes [:jdescottes]]

Ah I see there is frameBrowsingContextID on the loadInfo, which seems to do exactly what I asked. Leaving the ni? in case you have some more insights, but looks like we have enough to fix it on our own.

Comment 3

[Valentin Gosu [:valentin] (he/him)]

I don't have any more info. I'm glad frameBrowsingContext gets you the information you need.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1869735 - [devtools] Use frameBrowsingContextID if available in network getChannelBrowsingContextID

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1869735 - [wdspec] Add a network event test asserting iframe navigations

Depends on D196326

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/478e4fb80c4d
[devtools] Use frameBrowsingContextID if available in network getChannelBrowsingContextID r=webdriver-reviewers,devtools-reviewers,bomsy,whimboo
https://hg.mozilla.org/integration/autoland/rev/1b43e68405d0
[wdspec] Add a network event test asserting iframe navigations r=webdriver-reviewers,whimboo

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43690 for changes under testing/web-platform/tests

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/478e4fb80c4d
https://hg.mozilla.org/mozilla-central/rev/1b43e68405d0

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot