1869944 - Permafailing snap-beta and stap-stable builds due to unexpected zstandard version

Status: RESOLVED FIXED

(Firefox Build System :: Third Party Packaging, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://firefoxci.taskcluster-artifacts.net/VUOvkkNDSx-8ByP6L5NBuQ/1/public/logs/live_backing.log

:: zstandard<=0.19.0,>=0.11.1: Installed with unexpected version "0.22.0"
:: Creating global state directory from environment variable: /builds/worker/firefox-snap/parts/firefox/build/.mozbuild
:: Running "pip check" to verify compatibility between the system Python and the "mach" site.
:: Traceback (most recent call last):
::   File "/builds/worker/firefox-snap/parts/firefox/build/./mach", line 168, in <module>
::     main(sys.argv[1:])
::   File "/builds/worker/firefox-snap/parts/firefox/build/./mach", line 131, in main
::     mach = check_and_get_mach(os.path.dirname(os.path.realpath(__file__)), args)
::   File "/builds/worker/firefox-snap/parts/firefox/build/./mach", line 38, in check_and_get_mach
::     return load_mach(dir_path, mach_path, args)
::   File "/builds/worker/firefox-snap/parts/firefox/build/./mach", line 24, in load_mach
::     return mach_initialize.initialize(dir_path, args)
::   File "/builds/worker/firefox-snap/parts/firefox/build/build/mach_initialize.py", line 164, in initialize
::     _activate_python_environment(
::   File "/builds/worker/firefox-snap/parts/firefox/build/build/mach_initialize.py", line 92, in _activate_python_environment
::     mach_environment.activate()
::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mach/mach/site.py", line 369, in activate
::     self.ensure()
::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mach/mach/site.py", line 347, in ensure
::     result = self._up_to_date()
::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mach/mach/site.py", line 335, in _up_to_date
::     _assert_pip_check(self._sys_path(), "mach", self._requirements)
::   File "/builds/worker/firefox-snap/parts/firefox/build/python/mach/mach/site.py", line 1212, in _assert_pip_check
::     raise Exception(
:: Exception: The "mach" site is not compatible with the installed system Python packages.
'override-build' in part 'firefox' failed with code 1.
Review the scriptlet and make sure it's correct.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1869944 - Relax the version of zstandard allowed by the mach site.

Comment 2

[Mike Hommey [:glandium]]

I'll go with the easy fix for now, but we'll have to find something better to avoid having to do this every time we upgrade zstandard on central.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1860630

Comment 4

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/d3f36cd59003

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/c0760ddf4c36

Comment 6

[Intermittent Failures Robot]

17 failures in 4224 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 17

Platform and build breakdown:

• linux64-snap-amd64-beta: 8
  • opt: 4
  • debug: 4
• linux64-snap-amd64-stable: 9
  • opt: 5
  • debug: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1869944&startday=2023-12-11&endday=2023-12-17&tree=all

Comment 7

[Intermittent Failures Robot]

10 failures in 3349 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 10

Platform and build breakdown:

• linux64-snap-amd64-beta: 2
  • debug: 1
  • opt: 1
• linux64-snap-amd64-stable: 8
  • debug: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1869944&startday=2023-12-18&endday=2023-12-24&tree=all

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1869944 - Let mach use the mach site when building snaps.

The system environment under which the snaps are built doesn't always
match the tree that is built. When the versions of system python
packages doesn't match what is in the tree (like when upgrading
zstandard in the docker image, and building an older tree that wants
an older version), we get in a troublesome situation.

So just rely on the mach virtualenv.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d822c618985
Let mach use the mach site when building snaps. r=firefox-build-system-reviewers,sergesanspaille

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8d822c618985

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/31644660caa0

Comment 12

[Intermittent Failures Robot]

6 failures in 1162 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6

Platform and build breakdown:

• linux64-snap-amd64-stable: 4
  • opt: 2
  • debug: 2
• linux64-snap-amd64-nightly: 2
  • opt: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1869944&startday=2023-12-25&endday=2023-12-31&tree=all