1870959 - Permafailing Linux snap build: 'override-build' in part 'firefox' failed with code 1 after No file to patch. Skipping patch on different files

Status: RESOLVED FIXED

(Firefox Build System :: Third Party Packaging, defect)

Description

[Natalia Csoregi [:nataliaCs]]

• Push with failures: https://treeherder.mozilla.org/jobs?repo=mozilla-central&group_state=expanded&revision=7c63a9afa9648007a6ae98a90d09bb3cd2b45cba&searchStr=linux%2Csnap&selectedTaskRun=b-SthZUxTK2brmK2jegR1w.0

• Failure log example: https://treeherder.mozilla.org/logviewer?job_id=440778927&repo=mozilla-central

[task 2023-12-20T00:30:43.620Z] :: Applying patch /builds/worker/firefox-snap/patches/native-messaging-portal.patch
[task 2023-12-20T00:30:43.620Z] :: patching file modules/libpref/init/StaticPrefList.yaml
[task 2023-12-20T00:30:43.620Z] :: Hunk #1 succeeded at 15709 (offset 175 lines).
[task 2023-12-20T00:30:43.620Z] :: patching file python/mozbuild/mozbuild/mozinfo.py
[task 2023-12-20T00:30:43.620Z] :: Hunk #1 succeeded at 151 with fuzz 2 (offset 5 lines).
[task 2023-12-20T00:30:43.620Z] :: patching file testing/mozharness/configs/unittests/linux_unittest.py
[task 2023-12-20T00:30:43.620Z] :: Hunk #1 succeeded at 34 (offset 1 line).
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2023-12-20T00:30:43.620Z] :: Hunk #3 succeeded at 132 (offset 3 lines).
[task 2023-12-20T00:30:43.620Z] :: Hunk #4 succeeded at 356 (offset 3 lines).
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.h
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.cpp
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/components.conf
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/moz.build
[task 2023-12-20T00:30:43.620Z] :: Hunk #1 succeeded at 76 (offset -1 lines).
[task 2023-12-20T00:30:43.620Z] :: Hunk #2 succeeded at 103 (offset -1 lines).
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/nsINativeMessagingPortal.idl
[task 2023-12-20T00:30:43.620Z] :: can't find file to patch at input line 967
[task 2023-12-20T00:30:43.620Z] :: Perhaps you used the wrong -p or --strip option?
[task 2023-12-20T00:30:43.620Z] :: The text leading up to this was:
[task 2023-12-20T00:30:43.620Z] :: --------------------------
[task 2023-12-20T00:30:43.620Z] :: |--- a/toolkit/components/extensions/test/xpcshell/native_messaging.ini
[task 2023-12-20T00:30:43.620Z] :: |+++ b/toolkit/components/extensions/test/xpcshell/native_messaging.ini
[task 2023-12-20T00:30:43.620Z] :: --------------------------
[task 2023-12-20T00:30:43.620Z] :: No file to patch.  Skipping patch.
[task 2023-12-20T00:30:43.620Z] :: 1 out of 1 hunk ignored
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/modules/subprocess/Subprocess.sys.mjs
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/modules/subprocess/subprocess_common.sys.mjs
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/modules/subprocess/subprocess_unix.sys.mjs
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/modules/subprocess/subprocess_win.sys.mjs
[task 2023-12-20T00:30:43.620Z] :: Hunk #1 succeeded at 168 (offset -5 lines).
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/modules/subprocess/subprocess_worker_common.js
[task 2023-12-20T00:30:43.620Z] :: can't find file to patch at input line 1534
[task 2023-12-20T00:30:43.620Z] :: Perhaps you used the wrong -p or --strip option?
[task 2023-12-20T00:30:43.620Z] :: The text leading up to this was:
[task 2023-12-20T00:30:43.620Z] :: --------------------------
[task 2023-12-20T00:30:43.620Z] :: |--- a/toolkit/modules/subprocess/subprocess_worker_unix.js
[task 2023-12-20T00:30:43.620Z] :: |+++ b/toolkit/modules/subprocess/subprocess_worker_unix.js
[task 2023-12-20T00:30:43.620Z] :: --------------------------
[task 2023-12-20T00:30:43.620Z] :: No file to patch.  Skipping patch.
[task 2023-12-20T00:30:43.620Z] :: 3 out of 3 hunks ignored
[task 2023-12-20T00:30:43.620Z] :: can't find file to patch at input line 1581
[task 2023-12-20T00:30:43.620Z] :: Perhaps you used the wrong -p or --strip option?
[task 2023-12-20T00:30:43.620Z] :: The text leading up to this was:
[task 2023-12-20T00:30:43.620Z] :: --------------------------
[task 2023-12-20T00:30:43.620Z] :: |--- a/toolkit/modules/subprocess/subprocess_worker_win.js
[task 2023-12-20T00:30:43.620Z] :: |+++ b/toolkit/modules/subprocess/subprocess_worker_win.js
[task 2023-12-20T00:30:43.620Z] :: --------------------------
[task 2023-12-20T00:30:43.620Z] :: No file to patch.  Skipping patch.
[task 2023-12-20T00:30:43.620Z] :: 1 out of 1 hunk ignored
[task 2023-12-20T00:30:43.620Z] :: patching file toolkit/modules/subprocess/test/xpcshell/test_subprocess.js
[task 2023-12-20T00:30:43.620Z] :: patching file widget/gtk/WidgetUtilsGtk.h
[task 2023-12-20T00:30:43.620Z] :: Hunk #1 succeeded at 54 (offset 1 line).
[task 2023-12-20T00:30:43.620Z] :: patching file widget/gtk/WidgetUtilsGtk.cpp
[task 2023-12-20T00:30:43.620Z] :: Patch /builds/worker/firefox-snap/patches/native-messaging-portal.patch does not apply (enforce with -f)
[task 2023-12-20T00:30:43.620Z] 'override-build' in part 'firefox' failed with code 1.
[task 2023-12-20T00:30:43.620Z] Review the scriptlet and make sure it's correct.
[task 2023-12-20T00:30:43.620Z] Full execution log: '/builds/worker/.local/state/snapcraft/log/snapcraft-20231220-000750.414582.log'
[taskcluster 2023-12-20 00:30:53.960Z] === Task Finished ===
[taskcluster 2023-12-20 00:30:54.281Z] Unsuccessful task run with exit code: 1 completed in 1551.928 seconds

Mike, can you take a look at this?
Thank you.

Comment 1

[Mike Hommey [:glandium]]

This comes from an upstream patch.

Comment 2

[:gerard-majax]

Looks like the beta branch needs to be updated as well now. I suspect we'll start seeing PGO failures on beta after this ?

Comment 3

[:gerard-majax]

Ok, I see the patches have been updated (and PGO disabled): https://github.com/canonical/firefox-snap/commits/beta

Comment 4

[Intermittent Failures Robot]

19 failures in 3349 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 19

Platform and build breakdown:

• linux64-snap-amd64-beta: 3
  • debug: 2
  • opt: 1
• linux64-snap-amd64-stable: 8
  • debug: 4
  • opt: 4
• linux64-snap-amd64-nightly: 8
  • debug: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1870959&startday=2023-12-18&endday=2023-12-24&tree=all

Comment 5

[Cosmin Sabou [:CosminS]]

Latest log looks something like this:

[task 2023-12-30T00:13:51.198Z] :: patching file python/mozbuild/mozbuild/mozinfo.py
[task 2023-12-30T00:13:51.198Z] :: patching file python/sites/xpcshell-test.txt
[task 2023-12-30T00:13:51.198Z] :: patching file testing/mozharness/configs/unittests/linux_unittest.py
[task 2023-12-30T00:13:51.198Z] :: patching file testing/xpcshell/mach_commands.py
[task 2023-12-30T00:13:51.198Z] :: patching file toolkit/components/extensions/NativeManifests.sys.mjs
[task 2023-12-30T00:13:51.198Z] :: patching file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2023-12-30T00:13:51.198Z] :: Hunk #3 FAILED at 48.
[task 2023-12-30T00:13:51.198Z] :: Hunk #4 succeeded at 74 (offset 8 lines).
[task 2023-12-30T00:13:51.198Z] :: Hunk #5 succeeded at 93 (offset 8 lines).
[task 2023-12-30T00:13:51.198Z] :: Hunk #6 succeeded at 142 (offset 8 lines).
[task 2023-12-30T00:13:51.198Z] :: Hunk #7 succeeded at 379 (offset 8 lines).
[task 2023-12-30T00:13:51.198Z] :: 1 out of 7 hunks FAILED -- rejects in file toolkit/components/extensions/NativeMessaging.sys.mjs
[task 2023-12-30T00:13:51.198Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.cpp
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/NativeMessagingPortal.h
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/components.conf
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/docs/native-messaging-portal-design.rst
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/moz.build
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/nsINativeMessagingPortal.idl
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/test/xpcshell/native_messaging.toml
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_portal.js
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/components/extensions/test/xpcshell/test_native_manifests.js
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/Subprocess.sys.mjs
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/subprocess_common.sys.mjs
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/subprocess_unix.sys.mjs
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/subprocess_unix.worker.js
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/subprocess_win.sys.mjs
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/subprocess_win.worker.js
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/subprocess_worker_common.js
[task 2023-12-30T00:13:51.199Z] :: patching file toolkit/modules/subprocess/test/xpcshell/test_subprocess.js
[task 2023-12-30T00:13:51.199Z] :: patching file widget/gtk/WidgetUtilsGtk.cpp
[task 2023-12-30T00:13:51.199Z] :: patching file widget/gtk/WidgetUtilsGtk.h
[task 2023-12-30T00:13:51.199Z] :: Patch /builds/worker/firefox-snap/patches/native-messaging-portal.patch does not apply (enforce with -f)
[task 2023-12-30T00:13:51.199Z] 'override-pull' in part 'firefox' failed with code 1.
[task 2023-12-30T00:13:51.199Z] Review the scriptlet and make sure it's correct.
[task 2023-12-30T00:13:51.199Z] Full execution log: '/builds/worker/.local/state/snapcraft/log/snapcraft-20231230-000905.681669.log'
[taskcluster 2023-12-30 00:13:58.139Z] === Task Finished ===
[taskcluster 2023-12-30 00:14:00.085Z] Unsuccessful task run with exit code: 1 completed in 447.7 seconds

Comment 6

[Intermittent Failures Robot]

20 failures in 1162 pushes (0.017 failures/push) were associated with this bug in the last 7 days.

This is the #50 most frequent failure this week.

Repository breakdown:

• mozilla-central: 20

Platform and build breakdown:

• linux64-snap-amd64-stable: 6
  • debug: 3
  • opt: 3
• linux64-snap-amd64-nightly: 14
  • debug: 6
  • opt: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1870959&startday=2023-12-25&endday=2023-12-31&tree=all

Comment 7

[:gerard-majax]

So it looks like something made the upstream patch bitrot again and people are still on PTO

Comment 8

[Intermittent Failures Robot]

15 failures in 2274 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 15

Platform and build breakdown:

• linux64-snap-amd64-nightly: 15
  • opt: 8
  • debug: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1870959&startday=2024-01-01&endday=2024-01-07&tree=all

Comment 9

[:gerard-majax]

First failure was december 22: https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=Snap&fromchange=8fd04cb03fbd84435d9834d1de340c2f64e013bb&selectedTaskRun=OXsNAxf3RRSLNKaAm8nklw.0

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1869678

Comment 11

[:gerard-majax]

Attachment: GitHub Pull Request

Comment 12

[:gerard-majax]

upstream merged the pr, retriggers are green: https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=linux64-snap&revision=fa142c3f71b8a5f5e5781fe41471dc1528cecd75

Comment 13

[Intermittent Failures Robot]

3 failures in 3217 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform and build breakdown:

• linux64-snap-amd64-nightly: 3
  • debug: 2
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1870959&startday=2024-01-08&endday=2024-01-14&tree=all