1870258 - Sidebar does not follow OS theme

Status: VERIFIED FIXED

(Core :: Widget, defect, P3)

Description

[Takanori MATSUURA]

Attachment: Screenshot. Red area is the regression. Green area means "System theme — auto" is selected.

Steps to reproduce:

1. OS theme is set to dark
2. Start Firefox
3. Apply "System theme — auto" theme
4. Show sidebar

Expected result:
Sidebar should be set to the dark theme.

Actual Result:
Sidebar is set to the light theme.

Additional Information:
Tested on Firefox Nightly win64

Regression range by mozregression:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=691e5b3199934b481e0e7130b07a9f0928d8c62c&tochange=66ce07c162324dbea9047a4344cf908cffb863d0

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1869299

:emilio, since you are the author of the regressor, bug 1869299, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

I can't seem to reproduce this on Ubuntu 23.10.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1870258 - Add generic dark -moz-sidebar colors. r=dao

Windows is the only platform which doesn't have proper native system
colors, and we have to emulate them. Preserve behavior by returning the
same that field/fieldtext etc used to return.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d19e1f44e56
Add generic dark -moz-sidebar colors. r=dao

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2d19e1f44e56

Comment 6

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 122.0a1 (2023-12-15) on Windows 10.
The issue is verified fixed with Firefox 123.0a1 (20231221170215) and Firefox 122.0b2 (20231220091547) on Windows 10.