Consider updating the GTK3 adwaita colors to use the libadwaita ones.
Categories
(Core :: Widget: Gtk, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
()
Details
Attachments
(5 files, 1 obsolete file)
|
Assignee | |
Updated•9 months ago
|
|
||
Updated•9 months ago
|
|
|
Assignee | |
Comment 1•9 months ago
|
||
We might want to use this conditionally for the default GNOME theme. In
any case it's not a lot of code so it shouldn't hurt to land this
separately.
|
||
Updated•9 months ago
|
|
|
||
Updated•9 months ago
|
|
|
Assignee | |
Comment 2•9 months ago
|
||
This will be useful for Adwaita. Keep the field colors in this patch
tho.
|
|
Assignee | |
Comment 3•9 months ago
|
||
This will allow to easily tweak the front-end for selected / known-good
themes.
Depends on D196150
|
|
Assignee | |
Comment 4•9 months ago
|
||
Depends on D196151
|
|
Assignee | |
Comment 5•9 months ago
|
||
Take the colors from the libadwaita documentation. Do a couple tweaks to
the urlbar too to match both our default themes and adwaita.
Depends on D196152
|
|
||
Updated•9 months ago
|
|
|
Assignee | |
Comment 6•9 months ago
|
||
Depends on D196153
|
|
Assignee | |
Updated•9 months ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66ce07c16232 Generalize -moz-mac-sidebar into a cross-platform -moz-sidebar{,text,border} set. r=dao,desktop-theme-reviewers,win-reviewers,gstoll
| Comment hidden (advocacy) |
|
|
Assignee | |
Comment 9•9 months ago
|
||
It is consistent. It'll just use the libadwaita system colors for titlebars / sidebars rather than the GTK3 ones.
|
||
Comment 10•9 months ago
|
||
(In reply to {third: "Beedell", first: "Roke"}{.JSON5} from comment #8)
Don't do this.
Err, who are you to use imperative language here? Please don't use such language.
Either use a separate toolkit (or none) or use GTK4.
Changing the toolkit is a lot of work and not very realistic currently (as long a you don't volunteer to do the work).
|
||
Comment 11•9 months ago
|
||
Good to hear, emilio@crisal.io. Apologies for doubtin ya.
|
||
Comment 12•9 months ago
|
||
| bugherder | ||
|
||
Comment 13•9 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d118be4c03d Expose a media query for known gtk theme families. r=rmader
|
|
||
Comment 14•9 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34533b3add99 Remove some dead gtk lookandfeel code. r=rmader
|
|
||
Comment 15•9 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89da90df398f More modern Linux theme colors and looks. r=dao,stransky,desktop-theme-reviewers,rmader
|
|
||
Comment 16•9 months ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a54a846dda9a Clean up tab border set-up. r=dao,desktop-theme-reviewers
|
||
Updated•9 months ago
|
|
||
Comment 17•9 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8d118be4c03d
https://hg.mozilla.org/mozilla-central/rev/34533b3add99
https://hg.mozilla.org/mozilla-central/rev/89da90df398f
https://hg.mozilla.org/mozilla-central/rev/a54a846dda9a
|
|
||
Comment 18•9 months ago
|
||
Sorry for the noise but: awesome, thanks a lot \o/
|
||
Comment 19•9 months ago
|
||
looks like this caused 2 small regressions in DevTools:
== Change summary for alert #40690 (as of Sat, 16 Dec 2023 04:28:11 GMT) ==
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 6% | damp browser-toolbox.close-process.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 49.69 -> 52.87 |
| 3% | damp browser-toolbox.webconsole-ready.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 635.16 -> 651.43 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=40690
(I'm not super confident about this as the graphs around the alert is pretty busy)
|
|
Assignee | |
Comment 20•9 months ago
|
||
How sure are you of comment 19 Nicolas? Could we narrow it down a bit more? I did each commit on a different push so that it was easy to track potential regression but the pushlog from your alert seems huge. FWIW things seem to have gone back to previous values.
|
|
||
Comment 21•9 months ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #20)
How sure are you of comment 19 Nicolas? Could we narrow it down a bit more? I did each commit on a different push so that it was easy to track potential regression but the pushlog from your alert seems huge. FWIW things seem to have gone back to previous values.
not sure at all! And yes, the graphs seems to confirm that the value are now the same as before, we can ignore my comment. Sorry about the noise
Description
•