Closed Bug 1870793 Opened 1 year ago Closed 11 months ago

Tabs are slimmed down on tabs tray when in portrait mode on Samsung S8 tablet

Categories

(Fenix :: Tabs, defect, P3)

Firefox 120
All
Android
defect

Tracking

(firefox121 affected, firefox122 affected, firefox123 affected)

RESOLVED WORKSFORME
Tracking Status
firefox121 --- affected
firefox122 --- affected
firefox123 --- affected

People

(Reporter: mlobontiuroman, Unassigned)

References

Details

Attachments

(2 files)

Steps to reproduce

  1. Have at least 2 tabs opened.
  2. Tap on the tabs counter.
  3. Observe the tabs UI on the tabs tray when the device is in portrait mode.
  4. Rotate the device from portrait to landscape, and viceversa, if the bug isn't visible.

Expected behavior

The tabs are displayed correctly.

Actual behavior

Tabs are slimmed down on tabs tray when in portrait mode on Samsung S8 tablet.
Also, the "Tab closed UNDO" snackbar is displayed in the middle of the screen.

Device information

  • Firefox versions: Beta 122.0b1, Nightly 123.0a1 from 12/19, RC 121.0
  • Android device: Samsung Galaxy Tab S8 Ultra (Android 12)

Any additional information?

  • Not reproducible on Lenovo tab M10 (Android 10), Lenovo Yoga Tab 11 (Android 11), Huawei MediaPad M3 (Android 7), Samsung Galaxy Tab S3 (Android 9), and Samsung Galaxy Tab A7 (Android 13)
See Also: → 1866653
Priority: -- → P3

I have this same bug on a Samsung Galaxy S10 running Android 12. It started happening a few months ago.

If I open Firefox in landscape and then rotate to portrait, the tabs are very skinny. If I open Firefox in portrait and then rotate to landscape, the tabs are very wide.

My guess is that when Firefox boots, it decides what percent of the screen width tabs should be, and doesn't change that percent when you rotate the screen.

Encountered the skinny tabs on portrait on the following device:
Pixel 6 pro
Android 14
Firefox Android v121.1.0
Had 40+ tabs open
Low battery: at about 26%

After restarting the app, the tab widths went back to normal. And I have not encountered the problem since.

This bug is introduce by bug 1866653.
Also this could be fixed with the same PR for bug 1855519.

The key reason is the resources is not updated when configuration changed (like rotation/fold etc...).

See Also: → 1855519
Duplicate of this bug: 1875683

Hey Mira, there have been some changes pushed recently which should fix how device configuration changes, like rotation, are handled. Whenever you have a chance, could you please verify if this bug is still present?

Flags: needinfo?(mlobontiuroman)

Verified on the latest Fenix Nightly 126.0a1 from 4/4, on the 124.2.0 release, and on Beta 125.0b8, with the Samsung Galaxy Tab S8 Ultra (Android 12), and I'm no longer able to reproduce this issue.
I'll close this ticket as WORKSFORME.

Thank you!

Status: NEW → RESOLVED
Closed: 11 months ago
Flags: needinfo?(mlobontiuroman)
Resolution: --- → WORKSFORME
See Also: → 1889692
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: