1866653 - tabs are too wide in grid view on Samsung Z-fold 3

Status: RESOLVED FIXED

(Fenix :: Tabs, defect, P3)

Description

[ianfinleyhome]

Attachment: Screenshot_20231125_140241_Firefox Beta.png

User Agent: Mozilla/5.0 (Android 13; Mobile; rv:121.0) Gecko/121.0 Firefox/121.0

Steps to reproduce:

Using Firefox Beta for Android [121.0b3 (Build #2015987799), 29156d3ce8+
GV: 121.0-20231124091512
AS: 121.0] (this is a brand new problem as of the update installed last night)
On a Verizon Samsung Z-fold 3 using the outer screen (with the phone folded) set tab view to Grid, then view the open tabs

Actual results:

Tabs appear in one stretched and distorted column(See attached screenshot).

Expected results:

Tabs should still appear in two columns, or grid mode should allow me to customize the number of columns on my device. With only one column, this is just a worse version of list view. When using the larger inner screen, tabs still appear in three columns, which is a useful width.

Comment 1

[Noah Bond [:007]]

Hey :ianfinleyhome, thanks for filing this bug. We just enabled a UI rewrite for the Tabs Tray in Beta, so it's possible you're seeing a bug related to that.

To help with debugging, what happens in the following scenarios:

• Start unfolded (inner screen) -> Open the tabs tray
• Start unfolded (inner screen) -> Open the tabs tray -> Fold to the use the outer screen
• Start folded (outer screen) -> Open the tabs tray -> Unfold to use the inner screen
• Start folded (outer screen) -> Open the tabs tray -> Rotate the device to landscape

Comment 2

[ianfinleyhome]

(In reply to Noah Bond [:007] from comment #1)

Hey :ianfinleyhome, thanks for filing this bug. We just enabled a UI rewrite for the Tabs Tray in Beta, so it's possible you're seeing a bug related to that.

To help with debugging, what happens in the following scenarios:

• Start unfolded (inner screen) -> Open the tabs tray
• Start unfolded (inner screen) -> Open the tabs tray -> Fold to the use the outer screen
• Start folded (outer screen) -> Open the tabs tray -> Unfold to use the inner screen
• Start folded (outer screen) -> Open the tabs tray -> Rotate the device to landscape

In order:

• The tab grid is 3 columns wide, as expected.
• The tab grid changes to 1 stretched column as soon as the screen changes to the outer one
• The tab grid changes back to 3 columns as soon as the screen changes back to the inner screen (though I noticed a couple frames of some kind of animation playing, it seemed, as the tabs shifted into place)
• The tabs shifted into a 4 column arrangement as I changed the outer screen into landscape mode, which seems like a reasonable and useful number of columns for that display mode.

Comment 3

[Noah Bond [:007]]

OK cool. So it sounds like the bug is isolated to just to the unfolded, portrait configuration then. Thanks for the quick response with the info!!

I have a hypothesis of what the culprit is after doing some quick investigation. I think we're doing the math for determining the number of columns a little differently after the rewrite and not enforcing a two-column minimum.

I may not get a fix candidate out this week, as I'm going on PTO soon, but this comment thread will be notified as soon as a pull request is out for review!

Thanks again for your help!

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1866653 - Ensure the tab grid has a minimum of two columns (#4715)

Comment 5

[BMO Github Automation]

Authored by https://github.com/MozillaNoah
https://github.com/mozilla-mobile/firefox-android/commit/b301347adc8f0f4368e82deeaef535a9026697d0
[main] Bug 1866653 - Ensure the tab grid has a minimum of two columns

Comment 6

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly 122.0a1 from 8.12.2023 with Samsung GalaxyZ Fold 4 (Android 13).

Comment 7

[Adina Petridean QA [:apetridean]]

Attachment: fold.JPEG