1870887 - Keep Report Broken Site menu options hidden by default until the feature starts up

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

A user on Reddit has pointed out that on Firefox 121, they briefly see "Report Broken Site" in the app menu before it is hidden. This seems likely to be due to the button not being hidden by default here, and so it is briefly visible until the feature starts up and hides it here. This is only a problem if the feature is preffed off by default, of course. We will also want to treat the other two menu items similarly.

Comment 1

[Thomas Wisniewski [:twisniewski]]

Attachment: Bug 1870887 - hide the Report Broken Site menu options until the component initializes; r?gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3189af86c93a
hide the Report Broken Site menu options until the component initializes; r=Gijs

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3189af86c93a

Comment 4

[Donal Meehan [:dmeehan]]

:twisniewski is this something you could consider adding a beta uplift request?
There's still time to get this out in Fx122

Comment 5

[Thomas Wisniewski [:twisniewski]]

Comment on attachment 9369734 [details]
Bug 1870887 - hide the Report Broken Site menu options until the component initializes; r?gijs

Sure, we might as well do so. Thanks for the reminder!

Beta/Release Uplift Approval Request

• User impact if declined: Users may see the "Report Broken Site" option momentarily before it is hidden, if they do not have it enabled.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only affects the Report Broken Site feature, which is off by default except for users who may be enrolled in our limited-run experiment.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9369734 [details]
Bug 1870887 - hide the Report Broken Site menu options until the component initializes; r?gijs

Approved for 122.0b6

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f5e8c91e699