1871015 - Switching from dark mode to light mode and back doesn't always work in Firefox on Android (Samsung Galaxy S10)

Status: NEW

(Firefox for Android :: Design System and Theming, defect)

Description

[tuulen.ukko]

User Agent: Mozilla/5.0 (Android 12; Mobile; rv:120.0) Gecko/120.0 Firefox/120.0
Firefox for Android

Steps to reproduce:

I have selected in settings to follow the device theme. I have also configured Android to automatically switch from light to dark mode when it is day or night. When switching from one mode to the other (light to dark and the other way round) automatically, Firefox sometimes displays the opposite mode. If I then close and open the application it displays correctly. It looks like something is cached. Only happens to me on Android 12 on a Samsung Galaxy S10 with One Ui 4.1

Actual results:

Switching from dark mode to light mode and back doesn't always work in Firefox on Android (Samsung Galaxy S10)

Expected results:

Having selected to follow the theme of the device, when the mobile automatically switches from dark to light mode, Firefox should also change the theme to the running mode but it doesn't always do so.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I'm a victim of this bug too. I use Galaxy Tab S8+, even after upgrading to One UI 6, I reproduce this everyday.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Looks like that MODE_NIGHT_FOLLOW_SYSTEM is not handled? (Although I'm not familiar with Android app development.)
https://searchfox.org/mozilla-mobile/rev/05240c1438b2f3aa2603711d1dafa7051aa648db/firefox-android/fenix/app/src/main/java/org/mozilla/fenix/theme/ThemeManager.kt#50

Comment 4

[Mark]

I suffer from this issue too, I just filed bug 1873022, maybe it's one example of the more general issue??

Comment 5

[Eric[:ericswpark]]

Confirming the same behavior on a Z Fold5 running Android 14, One UI 6.0.
Firefox version is 122.1.0 (Build #2016001831)
When the bug occurs and the device is in light mode, Firefox will show in dark mode, but the text on the Settings page will assume light mode, making it impossible to read the labels.

Comment 6

[[e-mail]]

It only partially switches between modes. I have to force close and reopen to fix it. It also won't load pages when it's been theme borked.

Comment 7

[Markus Stange [:mstange]]

Attachment: Broken state after dark -> light transition

I can see some parts of the toolbar menu adapt to the new theme, but not all. This causes unreadable text for the Settings menu item and the Sync user email, and most of the icons become invisible too.

Comment 8

[Markus Stange [:mstange]]

Attachment: Broken state after light -> dark transition

Comment 9

[Christopher Higgins]

Confirming this behavior, and those screenshots, on Pixel 5a:

128.0 (Build #2016030615), hg-14b32d530926+
GV: 128.0-20240704121409
AS: 128.0.1

Comment 10

[Tyler]

Still an issue for me every day. Closing and reopening resolves it. The theme switches correctly when I change the mode manually but when the phone automatically switches between light and dark mode, Firefox does not switch correctly.

S24 Ultra
136.0.1 (Build #2016078447)
Android 14
One UI 6.1