1871040 - The Review Checker micro Survey Title is overlapped by the X Close button with DE builds

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2023-12-20_14h44_02.png

Found in

• Nightly 123.0a1 (2023-12-20)

Affected versions

• Nightly 123.0a1 (2023-12-20)
• Beta 122.0b1

Affected platforms

• ALL

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1

Have a DE build.

Steps to reproduce

1. Reach enough Product details pages until the micro Survey is triggered.
2. Select any option and reach the second slide.
3. Resize the Review Checker to a smaller size.

Expected result

• The Text should move to a second row before it reaches the X Close button.

Actual result

• The X Close button overlaps the text when the Review checker is at a smaller size.

Regression range
N/A

Comment 1

[Shane Hughes [:aminomancer]]

We need to add margin-right: "40px" to the title.

Comment 2

[Jason Prickett]

Attachment: Bug 1871040 - Add margin to shopping survey header to prevent dismiss overlap r?#omc-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0713de5c750a
Add margin to shopping survey header to prevent dismiss overlap r=omc-reviewers,aminomancer

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0713de5c750a

Comment 5

[Rares Doghi, Desktop QA]

Hi @jprickett, the issue underline issue from this bug no longer occurs, the X no longer overlaps the text but with the smallest size the X button is truncated now and a horizontal scrollbar is created, is this ok ?? please check our latest screenshot.

Comment 6

[Rares Doghi, Desktop QA]

Attachment: Survey.png

Comment 7

[Rares Doghi, Desktop QA]

I will mark this issue verified as fixed since the main issue here was fixed, and I think the other issue is related to Bug 1870805.

Comment 8

[Jason Prickett]

Hello @rdoghi! This is intentional, and is the fix suggested by the product team.