1871375 - Firefox titlebar (along with tabs) on Windows fades excessively when not focused

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Marco Bonardo [:mak]]

After the changes in Bug 1870100, now the whole titlebar, including tabs, fades when the window is not focused.
This may be expected (not sure), but the effect is excessive compared to other apps (e.g. VS Code).

This makes it look like Firefox is frozen.

I'll post some gifs soon.

Comment 1

[Marco Bonardo [:mak]]

Attachment: firefox_fade.gif

Comment 2

[Marco Bonardo [:mak]]

Attachment: vscode_fade.gif

Comment 3

[Marco Bonardo [:mak]]

Attachment: edge_fade.gif

Comment 4

[Emilio Cobos Álvarez (:emilio)]

It is expected. The .6 is historical / the opacity that Windows used to use for text yada yada. Using something like .75 or .8 should be fine.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

So on Linux, gtk uses .5 opacity, so current behavior doesn't look so out of place. On macOS I'm not sure, gotta check.

Comment 6

[Marco Bonardo [:mak]]

Attachment: onenote_fade.gif

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1870100

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Fade the titlebar less on Windows. r=dao

See comment for context.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Don't double-fade the titlebar buttons on Windows. r=dao

Depends on D197075

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Remove unused titlebar-color class in titlebar-items. r=dao

This is just drive-by clean-up while I was looking into the windows titlebar
buttons.

.titlebar-color is only used for toolbars here:

https://searchfox.org/mozilla-central/rev/8461ad1fc943ac560414322b66de5929ef10f706/browser/themes/shared/browser-shared.css#179

Depends on D197076

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Provide some subtle color feedback on inactive windows for our default themes. r=dao

This is a bit subtle but I think it's worth it. The frame colors are
changed from hex to rgb to make the parallel with browser-custom-colors
clearer.

Depends on D197077

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Inactive native sidebar on macOS

(Screenshot from Julian). The titlebar behaves the same too, fwiw, but the sidebar is relevant too since it has colored icons etc.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Libadwaita titlebar demo

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d79ff58c3ffc
Fade the titlebar less on Windows. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/abe6ed58f839
Don't double-fade the titlebar buttons on Windows. r=dao,desktop-theme-reviewers
https://hg.mozilla.org/integration/autoland/rev/71d4c5581b64
Remove unused titlebar-color class in titlebar-items. r=dao

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f405147cfcf
Provide some subtle color feedback on inactive windows for our default themes. r=dao,desktop-theme-reviewers

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d79ff58c3ffc
https://hg.mozilla.org/mozilla-central/rev/abe6ed58f839
https://hg.mozilla.org/mozilla-central/rev/71d4c5581b64
https://hg.mozilla.org/mozilla-central/rev/8f405147cfcf

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9369863 [details]
Bug 1871375 - Remove unused titlebar-color class in titlebar-items. r=dao

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple CSS tweak.
• String changes made/needed: none
• Is Android affected?: No

Comment 19

[Donal Meehan [:dmeehan]]

:emilio can you confirm only 3 out of the 4 patches are required to uplift? (just double checking)

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Yes, that was intentional, only 3 patches fix the regression. The other is a harmless tweak, which can be uplifted if wanted, but it's technically unrelated to the regression.

Comment 21

[Donal Meehan [:dmeehan]]

:emilio there are conflicts when grafting to beta caused by Bug 1870803

Comment 22

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Fade the titlebar less on Windows.

See comment for context.

Original Revision: https://phabricator.services.mozilla.com/D197075

Comment 23

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Don't double-fade the titlebar buttons on Windows.

Depends on D197075

Original Revision: https://phabricator.services.mozilla.com/D197076

Depends on D197458

Comment 24

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1871375 - Remove unused titlebar-color class in titlebar-items.

This is just drive-by clean-up while I was looking into the windows titlebar
buttons.

.titlebar-color is only used for toolbars here:

https://searchfox.org/mozilla-central/rev/8461ad1fc943ac560414322b66de5929ef10f706/browser/themes/shared/browser-shared.css#179

Depends on D197076

Original Revision: https://phabricator.services.mozilla.com/D197077

Depends on D197459

Comment 25

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: Comment 0
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Needs manual QE test: yes
• Code covered by automated testing: no
• String changes made/needed: none
• Is Android affected?: no
• Explanation of risk level: Trivial CSS change.
• Fix verified in Nightly: yes

Comment 26

[Emilio Cobos Álvarez (:emilio)]

(In reply to Donal Meehan [:dmeehan] from comment #21)

:emilio there are conflicts when grafting to beta caused by Bug 1870803

Ok, provided rebased versions, see above.

Comment 27

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/eba3f119f3ab
https://hg.mozilla.org/releases/mozilla-beta/rev/e2b41528efa7
https://hg.mozilla.org/releases/mozilla-beta/rev/3b8c3b52e3cc

Comment 28

[Ciprian Georgiu, Desktop QA]

I've looked at this bug and verified the fix on latest Beta 122.0b5 and Nightly 123.0a1 with Win 11. It seems that the fading effect is reproducing on Beta on a sublte way (expected), but the fading effect is the same as before the fix on Nightly 123.0a1 (I'm seeing what screenshot form comment 1 captures).

Emillio, we've also talked a bit on slack about this. I've made a screenshot (see here) comparing two Nightly builds, before and after the fix, where I cannot see any differences. Can you please take a look?

Comment 29

[Dão Gottwald [:dao]]

(In reply to Ciprian Georgiu, Desktop QA from comment #28)

Emillio, we've also talked a bit on slack about this. I've made a screenshot (see here) comparing two Nightly builds, before and after the fix, where I cannot see any differences. Can you please take a look?

FWIW, I can see the difference. Seems to work as expected.

Comment 30

[Emilio Cobos Álvarez (:emilio)]

You're looking at the effect duration, but you should look at how much it fades. This bug is specially noticeable on the titlebar buttons. But yeah I just checked and it seems to work as expected on b5

Comment 31

[Ciprian Georgiu, Desktop QA]

Thank you! Verified as fixed on Win 11 x64 with latest Beta 122.0b6 and Nightly 123.0a1.