1871389 - _showCustomizedAlert should not use popup=yes

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

From Emilio in bug 1870512 comment 9.

FYI I just noticed https://searchfox.org/comm-central/rev/fc51b5b1da584c4099d8e94d45b1ed3af521da1b/mailnews/base/src/MailNotificationManager.jsm#413. It specifies dialog=yes and popup=yes, which makes no sense. Likely just removing popup=yes there is the right way to go.

Comment 1

[Magnus Melin [:mkmelin]]

Removing that makes no difference in behavior so seems good.

The original behavior is a bit broken on daily (fine on 115). The notification should pop up in the bottom right corner, but I get it around the middle of my widescreen... which looks super weird.

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1871389 - _showCustomizedAlert should not use popup=yes. r=#thunderbird-reviewers

To test, Toggle off the "Use the system notification" and receive an email - check the notification.

Comment 3

[Intermittent Failures Robot]

1 failures in 3349 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 1

Platform and build breakdown:

• windows11-64-2009-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1871389&startday=2023-12-18&endday=2023-12-24&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a916e727094b
_showCustomizedAlert should not use popup=yes. r=aleca