1871613 - CanvasDrawEventRecorder no longer frees external surfaces used during recording

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

We no longer forward textures with RemoteTextureMap, hence this method no longer gets called:
https://searchfox.org/mozilla-central/rev/05178ae3d8ed27d47b340094de52bd3f572a5e1d/gfx/layers/ipc/CanvasChild.cpp#265

As such these external surfaces never get freed. We should just check when we are clearing resources and starting the next recording.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1871613 - Ensure CanvasDrawEventRecorder releases external surface dependencies.

This patch makes CanvasDrawEventRecorder track what eventCount we
recorded an external surface reference. When the reader has increment
its processedCount above that, we will release our reference as it
should have acquired a strong reference to the data. This was previously
done when we forwarded the texture, but with remote textures, we no
longer have this event. Now we check when we start a new recording, or
attempt to clear cached resources.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1871467

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/855ab22c063e
Ensure CanvasDrawEventRecorder releases external surface dependencies. r=gfx-reviewers,lsalzman

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/855ab22c063e