1871467 - Use RemoteTextureMap for D2D Canvas

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, enhancement)

Description

[Lee Salzman [:lsalzman]]

Right now we're using a mixture of RemoteTextureMap and replay textures in CanvasTranslator that is unwieldly. Replay textures are also slower than RemoteTextureMap, due to RemoteTextureMap being smarter about how it waits for availability of textures. Let's move D2D canvas over to RemoteTextureMap so that we can simplify the implementation of CanvasTranslator.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1871467 - Use RemoteTextureMap for D2D canvas. r?aosmond

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1871467 - Remove unused ReplayTexture support. r?aosmond

Depends on D197101

Comment 3

[Lee Salzman [:lsalzman]]

Initial testing suggests we should see something in between a 2-3% improvement in overall SP3 core on Windows from this.

Comment 4

[Lee Salzman [:lsalzman]]

Attachment: Bug 1871467 - Remove unnecessary CanvasTranslator locking. r?aosmond

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1c8e8621bdd
Use RemoteTextureMap for D2D canvas. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/0fd0c31a5140
Remove unused ReplayTexture support. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/1b02448b1e9b
Remove unnecessary CanvasTranslator locking. r=aosmond

Comment 6

[Natalia Csoregi [:nataliaCs]]

Backed out for causing reftest failures on transformations-1.html.

• backout: https://hg.mozilla.org/integration/autoland/rev/6814c9419790a8ee7c93cac282a82a11d93d16ba
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=bDMaNmOpRtOxSa2DtP75Dw.0&revision=1b02448b1e9b654275e339b84429fd9573ff09aa
• failure log: https://treeherder.mozilla.org/logviewer?job_id=441114997&repo=autoland&lineNumber=17084

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36c71343fb8c
Use RemoteTextureMap for D2D canvas. r=aosmond CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/c8cc337976e1
Remove unused ReplayTexture support. r=aosmond CLOSED TREE
https://hg.mozilla.org/integration/autoland/rev/92e647ae97ee
Remove unnecessary CanvasTranslator locking. r=aosmond CLOSED TREE

Comment 8

[Natalia Csoregi [:nataliaCs]]

Relanding this patch due to inaccurate backfill results.

Backfill pointed to this patch as being the culprit for the reftest failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=Linux%2C18.04%2Cx64%2CWebRender%2Cdebug%2CReftests%2Ctest-linux1804-64-qr%2Fdebug-reftest-snapshot%2CRs5&tochange=328ba82c361f4b9c538d46a8e2921552fc374e85&fromchange=3269da4317b52aa22899875f85180896861e301a&selectedTaskRun=bDMaNmOpRtOxSa2DtP75Dw.0

Sorry if this has caused any inconvenience!

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/36c71343fb8c
https://hg.mozilla.org/mozilla-central/rev/c8cc337976e1
https://hg.mozilla.org/mozilla-central/rev/92e647ae97ee

Comment 10

[Mayank Bansal]

Seems to be a 60% improvement on AWFY-MotionMark Animometer-Images sub-test
But the overall score shows a 3% regression

Comment 11

[Mayank Bansal]

And a probably 2.6% improvement on SP3 Windows

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Note that motionmark reported by awfy is run in some a bit weird mode.
-ramp version is, I believe, closer to what happens when one runs the test locally using its default mode
https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=1&highlightChangelogData=1&highlightCommonAlerts=0&series=mozilla-central,4921279,1,13&timerange=1209600