1871980 - Search expand/collapse image button on the Search bar lacks interactive role and expanded state

Status: RESOLVED FIXED

(Firefox :: Search, defect, P3)

Description

[Anna Yeddi [:ayeddi]]

searchbar-search-button includes two <image> elements, one of which is aimed to visually communicate that this overlay image could expand/collapse the search autosuggest list. This <hbox> that has an accessible name but lacks an appropriate interactive role and state, because it functions as a button (not focusable with keyboard because the alternative - Escape key - exists and works to collapse the autosuggest list and we do not want to create an additional tab stop for keyboard-only users). This would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc.

This issue is similar to the Go button on the URL bar resolved in the bug 1864962 and to the Submit search button tracked in bug 1871596

To activate the searchbar next to the URL Bar that includes this go button: about:preferences > Search > Search Bar > select Add search bar in toolbar.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1871980 - Add a programmatic role and expanded/collapsed state to the Search expand/collapse image button on the Searchbar. r=#search-reviewers!

searchbar-search-button includes two <image> elements, one of which is aimed to visually communicate that this overlay image could expand/collapse the search autosuggest list. This <hbox> that has an accessible name but lacks an appropriate interactive role and state, because it functions as a button (not focusable with keyboard because the alternative - Escape key - exists and works to collapse the autosuggest list and we do not want to create an additional tab stop for keyboard-only users). This would prevent users of speech-to-text/Voice Control from being able to send a click to it by calling its label and screen reader users and users of other assistive technology would not be able to get to this control via shortcuts like a list of controls, etc.

This issue is similar to the Go button on the URL bar resolved in the bug 1864962 and to the Submit search button tracked in bug 1871596

To activate the searchbar next to the URL Bar that includes this go button: about:preferences > Search > Search Bar > select Add search bar in toolbar.

Depends on D197202

Comment 2

[Cosmin Sabou [:CosminS]]

Hi Anna, any updates on this one? Bug 1872899 has now reached the disable recommended threshold with 177 total failures on trunk in the last 30 days: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2023-12-25&endday=2024-01-24&tree=trunk&failurehash=all&bug=1872899
The actual failure rate is combined with failures from https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2023-12-25&endday=2024-01-24&tree=trunk&failurehash=all&bug=1823573 as this is the one suggested in treeherder.
Should we mark it as fail-if on a11y until a fix is in place? Thank you.

Comment 3

[Anna Yeddi [:ayeddi]]

(In reply to Cosmin Sabou [:CosminS] from comment #2)

Hi Anna, any updates on this one? Bug 1872899 has now reached the disable recommended threshold with 177 total failures on trunk in the last 30 days: https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2023-12-25&endday=2024-01-24&tree=trunk&failurehash=all&bug=1872899
The actual failure rate is combined with failures from https://treeherder.mozilla.org/intermittent-failures/bugdetails?startday=2023-12-25&endday=2024-01-24&tree=trunk&failurehash=all&bug=1823573 as this is the one suggested in treeherder.
Should we mark it as fail-if on a11y until a fix is in place? Thank you.

Hi Cosmin, the patch is in the final stages of reviews: https://phabricator.services.mozilla.com/D197335 - I hope it'll be ready to land tomorrow (since both the Phab and Lando has been updating today). Thank you for reaching out to confirm the status, I appreciate it.

Comment 4

[Cosmin Sabou [:CosminS]]

Anna, if this is ready to go and takes care of the failures I'm happy to have this one https://phabricator.services.mozilla.com/D199648 reverted so that it provides more coverage on a11y_checks. I didn't know when this patch was going to land. Thank you.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57e7f16f456d
Add a programmatic role and expanded/collapsed state to the Search expand/collapse image button on the Searchbar. r=search-reviewers,Standard8,Jamie

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/57e7f16f456d