1872170 - Tapping on the screen after an upward overscroll on a page causes pull-to-refresh to be activated

Status: VERIFIED FIXED

(Firefox for Android :: Browser Engine, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: viewport.html

Steps to reproduce

1. Scroll down on the attached page viewport.html (test page taken from bug 1815657 but any site that has nested scrolling would work).
2. Scroll upward and in the same gesture, continue pulling upward more than the previous downward gesture from step 1.
3. Tap on the screen.

Expected behaviour

• Nothing happens.

Actual behaviour

• The Pull-To-Refresh throbber is activated.
• The throbber position is pulled down approximately the same distance as the over-scroll gesture from step 2.

Device information

• Firefox version: Firefox 122
• Android device model: All devices
• Android OS version: All versions

Any additional information?

• See attached video.
• Verified that this bug is a regression from bug 1847305 by reverting those patches and using the same STR.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Screen_recording_20231227_112558.mp4

Video of the bug being reproduced. Observe the touch tap gestures.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1847305

Comment 4

[Jonathan Almeida [:jonalmeida]]

Attachment: viewport.html

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox122 (beta) and tracked for firefox123 (nightly). We have limited time to fix this, the soft freeze is in 13 days. However, the bug still isn't assigned.

:jonalmeida, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 6

[Donal Meehan [:dmeehan]]

:jonalmeida could this be triaged for Severity?
Do you have any options to address this for Fx122, I added tracking based on the description. Can we consider backing out the regressor from Fx122 to give more time to address this with Fx123? Though the regressor is an S2.

Comment 7

[Jonathan Almeida [:jonalmeida]]

(In reply to Donal Meehan [:dmeehan] from comment #6)

:jonalmeida could this be triaged for Severity?

Settings has S3 for now because the pull-to-refresh feature is turned off by default in beta and release channels, so I am slightly less concerned about it.

(In reply to Donal Meehan [:dmeehan] from comment #6)

Do you have any options to address this for Fx122, I added tracking based on the description. Can we consider backing out the regressor from Fx122 to give more time to address this with Fx123? Though the regressor is an S2.

Titouan and I are going to discuss this more tomorrow after some more investigation and impact analysis when we both have overlapping timezones to debug together.

Keeping NI for both of us until then.

Comment 8

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1872170 - Fix Pull to Refresh triggered after an upward overscroll on a page (#5009)

Comment 9

[Jonathan Almeida [:jonalmeida]]

We have a patch that will solve this bug without needing to back-out the regressor - see comment 8.

We will let it bake over the weekend in nightly and request an uplift for 122 early next week.

Comment 11

[BMO Github Automation]

Authored by Titouan Thibaud
https://github.com/mozilla-mobile/firefox-android/commit/805b2ac0c0767cbe36b9c47e152954c98fc1fe20
[main] Bug 1872170 - Fix Pull to Refresh triggered after an upward overscroll on a page

Comment 13

[Adina Petridean QA [:apetridean]]

Attachment: az_recorder_20240108_112602.mov

Comment 14

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 123.0a1 from 01/08 with Motorola Moto G9 plus (Android 11) and OnePlus A3000 (Android 6).

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tthibaud, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Donal Meehan [:dmeehan]]

:tthibaud/:jonalemedia any concerns with adding an uplift request on this today?
Fenix 122.0b8 builds tomorrow. It would be good to include this now it's been verified and had a few days in Nightly.

Comment 17

[Jonathan Almeida [:jonalmeida]]

No, we're quite happy with the status of the patch, thanks for the reminder. Preparing an uplift request now.

Comment 18

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1872170 - Fix Pull to Refresh triggered after an upward overscroll on a page (backport #5009) (#5090)

Comment 19

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 9371762 [details] [review]
[mozilla-mobile/firefox-android] Bug 1872170 - Fix Pull to Refresh triggered after an upward overscroll on a page (backport #5009) (#5090)

Beta/Release Uplift Approval Request

• User impact if declined: Users will continue face unintentional page refreshes while they were only intending to scroll down a page, that can be quite frustrating.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Instructions provided in comment 0.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a low risk because the change has baked in nightly and verified by multiple users.
• String changes made/needed:
• Is Android affected?: Yes

Comment 20

[Donal Meehan [:dmeehan]]

Comment on attachment 9371762 [details] [review]
[mozilla-mobile/firefox-android] Bug 1872170 - Fix Pull to Refresh triggered after an upward overscroll on a page (backport #5009) (#5090)

Approved for Android 122.0b8

Comment 21

[BMO Github Automation]

Authored by Titouan Thibaud
https://github.com/mozilla-mobile/firefox-android/commit/01d24e7dddf91ef8e7b66eeaea4b01c12828d2a7
[releases_v122] Bug 1872170 - Fix Pull to Refresh triggered after an upward overscroll on a page

Comment 22

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox 123.0b8 with: Sony Xperia Z2 (Android 6.0.1) and Google Pixel 7 Pro ( Android 14).