1872327 - Don't leak runnables on shutdown in nsThreadPool

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Lee Salzman [:lsalzman]]

This bug is to deal specifically with one particular manifestation of bug 1767344 with CanvasTranslator that manifests as runnables being passed to nsThreadPool during shutdown, causing strange intermittents in the gpu subset of mochitests for remote canvas.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1872327 - Don't leak runnables on shutdown in nsThreadPool. r?aosmond

It looks like this was an oversight in bug 1155059, that in one place an
already_AddRefed does not get converted to a RefPtr.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601b104d4bb5
Don't leak runnables on shutdown in nsThreadPool. r=aosmond

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1155059

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/601b104d4bb5

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:lsalzman, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.