Open Bug 1872614 Opened 6 months ago Updated 6 months ago

AssertionError: Unable to find fzf when trying to ./mach perftest

Categories

(Testing :: mozperftest, defect, P2)

defect

Tracking

(Not tracked)

People

(Reporter: jmarshall, Unassigned)

References

Details

(Whiteboard: [fxp])

Running ./mach perftest <sometest> works, but without an arg:

$ ./mach perftest
Error running mach:

mach perftest

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ./mach busted to check if this issue is already on file. If it
isn't, please use ./mach busted file perftest to report it. If ./mach busted is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AssertionError: Unable to find fzf

File "/home/jcm/moz/perf-integration/mozilla-central/python/mozperftest/mozperftest/mach_commands.py", line 70, in run_perftest
selected = select(test_objects)
File "/home/jcm/moz/perf-integration/mozilla-central/python/mozperftest/mozperftest/fzf/fzf.py", line 99, in select
raise AssertionError("Unable to find fzf")

Sentry event ID: d43ba64a2fe845c4a15878890dda2377
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit

:jmarshall Do you have fzf installed at all anywhere? e.g. does ./mach try fuzzy work for you?
If you do have it installed it seems to not be in your path. If you don't have it installed, you may have to do that with your package manager.
(That is odd as i think it is by default installed when you bootstrap mozilla-central)

Flags: needinfo?(jmarshall)
Severity: -- → S3
Priority: -- → P2
Whiteboard: [fxp]

Yes mach try fuzzy works. I see fzf in ~/.mozbuild but it's not on my path.

Flags: needinfo?(jmarshall)

For this issue, what I'm thinking we'll do is remove the ability to call ./mach perftest with no arguments. It currently triggers a "push-to-try" feature that's unused/broken, and we don't plan on using it anymore given that we have ./mach try perf now.

You need to log in before you can comment on or make changes to this bug.