1872623 - Cancel button in SeaMonkey bookmarking star ui not working

Status: ASSIGNED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Frank-Rainer Grahl (:frg)]

When you edit a bookmark via our bookmarking star dialog in the urlbar Cancel does nothing in 2.53 up to 19b1pre when you edit fields. This is treated like "Done". The dialog in 2.57 with the sync bookmarking api removed undos the last transaction which, unless you entered values, is usually completely unrelated to this. I think the button should be removed. Not in Firefox.

There might be a way to fix this with deleting the undo transactions when the dialog opens but this might have side effects if you have the library open in a seperate window. A proper fix would probably needed named transactions in toolkit. The current api does not have this and just use an undo stack of the last commands from all over the place(s). Given that no one reported any problem here for 2.53.x, remove and done work fine I would go the easy way.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: TOP-1872623-cancelbookmark-25319.patch

This just disables the button. I also removed the flex spacer because both remaining buttions left aligned are working better for me.

Should I ask for review or kill the thing completely?

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9370670 [details] [diff] [review]
TOP-1872623-cancelbookmark-25319.patch

Late in the cycle so lets implement the kludge first.
[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: undesired behaviour with loos of recent bookmarks possible
Testing completed (on m-c, etc.): 2.53,19b1pre
Risk to taking this patch (and alternatives if risky) trivial:
String changes made by this patch: removal only commented out so far

Comment 3

[Ian Neal]

Comment on attachment 9370670 [details] [diff] [review]
TOP-1872623-cancelbookmark-25319.patch

[Triage Comment]
LGTM as a temporary kludge r/a=me