1456589 - Replace the Bookmark Manager with the Firefox Library in SeaMonkey: Followup bug

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #1378089 +++

Bug 1378089 replaced the Bookmarks Manager with a SeaMonkey specific version of the Firefox Library. 

This bug is a meta bug for the needed followup patches I plan to file:

1.) Address the comments from IanN wrt to bringing back the keywords column.
2.) Address the comments from IanN wrt to the missing column selection widget in the UI
3.) The checked in patches worked initially in SeaMonkey 2.57 but recent changes removed and also renamed functions. I need to track this down and open followup patches for 2.57+ (60+).

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part1-places-esr60.patch

There are a lot of bugs which needed backports so I will only address
 
3.) The checked in patches worked initially in SeaMonkey 2.57 but recent changes removed and also renamed functions. I need to track this down and open followup patches for 2.57+ (60+).

in this bug and move 1 and 2 out.

The 8 patches will bring the SeaMonkey places code mostly in line with Firefox ESR 60.

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part2-places-esr60.patch

Part 2

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part3-places-esr60.patch

Part 3

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part4-places-esr60.patch

Part 4

Comment 5

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part5-places-esr60.patch

Part 5

Comment 6

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part6-places-esr60.patch

Part 6

Comment 7

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part7-places-esr60.patch

Part 7

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1456589-part8-places-mopup.patch

Part 8 Cleanup patch does not port anything.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: original-patches.zip

Original ported and rebased patches for reference only.

Comment 10

[Ian Neal]

Comment on attachment 8992984 [details] [diff] [review]
1456589-part1-places-esr60.patch

LGTM straight port of Bug 1437651 r/a=me

Comment 11

[Ian Neal]

Comment on attachment 8992985 [details] [diff] [review]
1456589-part2-places-esr60.patch

r=me
a=me though we need to let l10n know about the late changes

Comment 12

[Ian Neal]

Comment on attachment 8992986 [details] [diff] [review]
1456589-part3-places-esr60.patch

LGTM r/a=me

Comment 13

[Ian Neal]

Comment on attachment 8992987 [details] [diff] [review]
1456589-part4-places-esr60.patch

LGTM r/a=me

Comment 14

[Ian Neal]

Comment on attachment 8992988 [details] [diff] [review]
1456589-part5-places-esr60.patch

LGTM r/a=me with usual l10n warning

Comment 15

[Ian Neal]

Comment on attachment 8992990 [details] [diff] [review]
1456589-part6-places-esr60.patch

Lots of shifting around and renaming of stuff
LGTM r/a=me

Comment 16

[Ian Neal]

Comment on attachment 8992991 [details] [diff] [review]
1456589-part7-places-esr60.patch

LGTM r/a=me

Comment 17

[Ian Neal]

Comment on attachment 8992992 [details] [diff] [review]
1456589-part8-places-mopup.patch

LGTM r/a=me

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4b570a748f30
Part 1 Port Bug 1437651 [Remove  unused simulated-places-node references]. r=IanN
https://hg.mozilla.org/comm-central/rev/6c1cd825c2b9
Part 2 Port Bug 1437242 1432614 1438511 1439313 1437583 1437310 1439358 3,6 to SeaMonkey places.  r=IanN
https://hg.mozilla.org/comm-central/rev/769411dc58db
Part 3 Port Bug 1440284 [change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules].  r=IanN
https://hg.mozilla.org/comm-central/rev/8ca24e8c7a6b
Part 4 Port Bug 1434376 and Bug 1432425 to SeaMonkey places. r=IanN
https://hg.mozilla.org/comm-central/rev/5515f2dd2916
Part 5 Port Bug 1435910 Part 0.1 [Move PlacesUIUtils.confirmOpenInTabs into new OpenInTabsUtils.jsm and add promiseConfirmOpenInTabs]. r=IanN
https://hg.mozilla.org/comm-central/rev/97c389019398
Part 6 Port Bug 1439315 [defineLazyScriptGetter controller.js] to SeaMonkey places. r=IanN
https://hg.mozilla.org/comm-central/rev/67150548fc03
Part 7 Port Bug 1442945 1440644 1443189 1444599 to SeaMonkey places. r=IanN
https://hg.mozilla.org/comm-central/rev/cd07afc8bcc3
Part 8 Remove unused telemetry calls and an accidently checked in file from SeaMonkey places. r=IanN

Comment 19

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/fdb3a87584ac
Part 1 Port Bug 1437651 [Remove unused simulated-places-node references]. r=IanN a=IanN
https://hg.mozilla.org/releases/comm-esr60/rev/f18a636061bf
Part 2 Port Bug 1437242 1432614 1438511 1439313 1437583 1437310 1439358 3,6 to SeaMonkey places. r=IanN a=IanN
https://hg.mozilla.org/releases/comm-esr60/rev/02dcc9039d68
Part 3 Port Bug 1440284 [change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules]. r=IanN a=IanN
https://hg.mozilla.org/releases/comm-esr60/rev/e5f6a52c52d3
Part 4 Port Bug 1434376 and Bug 1432425 to SeaMonkey places. r=IanN a=IanN 
https://hg.mozilla.org/releases/comm-esr60/rev/292194db3c07
Part 5 Port Bug 1435910 Part 0.1 [Move PlacesUIUtils.confirmOpenInTabs into new OpenInTabsUtils.jsm and add promiseConfirmOpenInTabs]. r=IanN a=IanN 
https://hg.mozilla.org/releases/comm-esr60/rev/a52ac7dae4b7
Part 6 Port Bug 1439315 [defineLazyScriptGetter controller.js] to SeaMonkey places. r=IanN a=IanN 
https://hg.mozilla.org/releases/comm-esr60/rev/3e3d8a6a9dde
Part 7 Port Bug 1442945 1440644 1443189 1444599 to SeaMonkey places. r=IanN a=IanN
https://hg.mozilla.org/releases/comm-esr60/rev/2d8a9e813140
Part 8 Remove unused telemetry calls and an accidently checked in file from SeaMonkey places. r=IanN a=IanN