Preview popup is displayed for primitive tokens
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(firefox123 fixed)
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
We're showing the popup for primitives (meaning hovering "booh" will show a popup with "booh" in it, not really useful)
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
In Popup, we were only adding/removing the highlight on hovered token on mount/unmount.
But it can happen that the component gets updated (e.g. when the user moves quickly
between valid tokens).
In such case, we want to remove the highlighted class on all elements that it was
set on, and only add it back on the "preview target".
We also want to update the Popover position so it points to the actual token the
preview was computed for.
Depends on D197565
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D197582
|
|
Assignee | |
Comment 4•1 year ago
|
||
I'm going to split this into multiple bugs so it's easier to follow
|
||
Comment 5•1 year ago
|
||
Comment on attachment 9370875 [details]
Bug 1872715 - [devtools] Update token highlight and popup position when Popup updates. r=#devtools-reviewers.
Revision D197582 was moved to bug 1873147. Setting attachment 9370875 [details] to obsolete.
|
|
||
Comment 6•1 year ago
|
||
Comment on attachment 9370882 [details]
Bug 1872715 - [devtools] Don't show preview popup if evaluated expression has SyntaxError. r=#devtools-reviewers.
Revision D197585 was moved to bug 1873149. Setting attachment 9370882 [details] to obsolete.
|
||
Comment 8•1 year ago
|
||
| bugherder | ||
Description
•