1875461 - inline preview widget should not be a valid target for preview popup/tooltip

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STRs:

1. Load http://janodvarko.cz/firebug/tests/601/Issue601.htm
2. Create BP on line 44
3. Click the POST button on the page to hit the BP
4. There should be inline preview for line 43, hover over it the tooltip says undefined => BUG

Honza

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2024-01-19 at 13.24.40.png

Which variable are you hovering Honza?Asking because I do see a preview for date

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: BUG

I am hovering over the inline preview itself. See the attached screenshot.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

oh right, I thought we took care of that, I probably regressed it, I'll have a look

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

I regressed it in Bug 1872715 . The funny thing is that we do have an assertion testing it (https://searchfox.org/mozilla-central/rev/47b65cbe249613b9af936cd4660789bb642a8e30/devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js#71-100), but the test is completely disabled :/ https://searchfox.org/mozilla-central/rev/47b65cbe249613b9af936cd4660789bb642a8e30/devtools/client/debugger/test/mochitest/browser_aj.toml#262-263

["browser_dbg-inline-preview.js"]
skip-if = ["true"] # bug 1607636

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1875461 - [devtools] Fix inline preview invalid targets. r=#devtools-reviewers.

The popup was displayed when hovering inline preview.
We move the assertion done in browser_dbg-inline-preview.js in browser_dbg-preview
as 1. it's where we run all the preview popup check, and 2. browser_dbg-inline-preview.js
is completely disabled (bug 1607636).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1872715

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/617a6db17dfe
[devtools] Fix inline preview invalid targets. r=devtools-reviewers,bomsy.

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/617a6db17dfe

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-01-17 Nightly build on Windows 10.
Verified as fixed on Firefox 123.0b9 on and Nightly 124.0a1 on Windows 10, macOS 12, Ubuntu 22.