1872743 - Default and Default Private Engine comboboxes in Settings UI are unlabelled

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Anna Yeddi [:ayeddi]]

The <menulist> with id defaultEngine that opens for the Default Search Engine selection on Settings > Search is not labelled. The combobox pattern is expected to provide an accessible name for the control even when the listbox opened has an accessible name.

We could refer to the #defaultEngineGroup container with aria-labelledby to ensure the combobox is labeled, and also to include a description via aria-describedby referred to the on-screen <description> provided for the control - this would communicate the purpose of opened list of options to an assistive technology user.

Same pattern could apply to the Default Private Engine <menulist>.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1872743 - Provide an accessible name to Default and Default Private Engine comboboxes in Settings UI. r=#settings-reviewers!

The <menulist> with id defaultEngine that opens for the Default Search Engine selection on Settings > Search is not labelled. The combobox pattern is expected to provide an accessible name for the control even when the listbox opened has an accessible name.

We could refer to the #defaultEngineGroup container with aria-labelledby to ensure the combobox is labeled, and also to include a description via aria-describedby referred to the on-screen <description> provided for the control - this would communicate the purpose of opened list of options to an assistive technology user.

Same pattern could apply to the Default Private Engine <menulist>.

Since the browser/components/preferences/tests/browser_searchDefaultEngine.js a11y_checks will be passing with this change, we are also removing the fail-if notation from its test manifest.

Depends on D197535

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/560520954716
Provide an accessible name to Default and Default Private Engine comboboxes in Settings UI. r=settings-reviewers,mossop

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/560520954716