1873025 - Sorting on recent tabs after search is confusing

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Screen Shot 2024-01-04 at 9.00.20 AM.png

I would've expected things to be shown in most recently used order, but as shown in the screenshot that is not the case. I haven't been able to figure out what order the list is in. It doesn't seem to match tab order either.

Comment 1

[Sarah Clements [:sclements]]

From what I can see it doesn't change the sort order at all, it preserves its positioning in the list which is still based on where it is in the tab strip (except for pinned tabs). Are you saying its not reflecting the order in the tab strip either?

I think once we implement bug 1855817 the order will be less confusing.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Screenshot showing that searching in recent browsing doesn't reflect tab order

Comment 3

[Jeff Muizelaar [:jrmuizel]]

(In reply to Sarah Clements [:sclements] from comment #1)

From what I can see it doesn't change the sort order at all, it preserves its positioning in the list which is still based on where it is in the tab strip (except for pinned tabs). Are you saying its not reflecting the order in the tab strip either?

Correct. It doesn't reflect the order in the tab strip either.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1873025 - Fix the displayed relative time for open tabs listing to match the recency sorting.r?#fxview-reviewers

• Carry over lastAccessed times from tabs that haven't been seen/active this session.
• Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25aa38248ad9
Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures at browser/base/content/test/tabs/browser_lastSeenActive.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/14759f9d57f24864706f47feb006248f5c509937

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_lastSeenActive.js | The expected window and tab is selected - Got "data:,Window2-Tab0", expected "data:,Window1-Tab0"

Comment 7

[Sam Foster [:sfoster] (he/him)]

Thanks for the backout. I think I see the issue. Updated patch incoming if my try push agrees with me.

Comment 8

[Sam Foster [:sfoster] (he/him)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #7)

Thanks for the backout. I think I see the issue. Updated patch incoming if my try push agrees with me.

It did not. It seems that minimizing and restoring a window doesn't necessarily change its order or "topness" according to BrowserWindowTracker. I'll update the tests accordingly.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2443d0b3d17d
Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_opentabs_recency.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/firefoxview/tests/browser/browser_opentabs_recency.js | The expected window is the top window - Got [object Window], expected [object Window]

Comment 11

[Sam Foster [:sfoster] (he/him)]

Thanks. The whack-a-mole continues.

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Any update on this? Sorting by recently used is still unusable.

Comment 14

[Sam Foster [:sfoster] (he/him)]

Yeah I have a patch ready to go that has been blocked on getting its tests un-disabled. That test patch is in review and should land this week which will let me land the patch here.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0fb272fbcad
Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c0fb272fbcad

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c0fb272fbcad

Comment 18

[Ina Popescu, Desktop QA]

I've replicated this issue using Nightly 123.0a1 on Windows 10 x64.
Verified as fixed in the latest Firefox 126.0b5 version on Windows10 x64, macOS 13, and Ubuntu 22.04, as the issue no longer occurs.