1873033 - [Ubuntu] Checkmark from Menu Bar checkbox is not entirely visible with High Contrast Theme.

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: checkmark.png

Found in

• Firefox 122.0b5

Affected versions

• Firefox 122.0b5
• Firefox 123.0a1

Tested platforms

• Affected platforms: Ubuntu 22
• Unaffected platforms: Windows 10, macOS 12

Preconditions

• Have High Contrast Theme set from OS system settings.

Steps to reproduce

1. Launch Firefox.
2. Go to Menu - More tools - Customize toolbars
3. Click on Menu Bar checkbox
4. Observe the checkmark from Menu Bar checkbox

Expected result

• The checkmark is entirely visible with High Contrast Theme.

Actual result

• The checkmark is not entirely visible with High Contrast Theme.

Regression range

• I will come back with regression range ASAP.

Additional notes

• Right click on toolbar and observe the Menu Bar checkmark, it is not visible either, see also View/Zoom/Zoom Text Only checkmark.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:zstimi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Daniel Bodea [:danibodea]]

Attachment: Screenshot from 2024-01-08 17-09-32.png

I could not reproduce this on my system. Furthermore, a different color and style is observed in all channels on my Ubuntu 22.

Comment 3

[Daniel Bodea [:danibodea]]

Please disregard my previous comment as I didn't manage to reproduce it correctly at the time.

It appears that there was a change that gave the blue color to the background of the checkbox to look more like the other checkmarks from the browser, but the design of the check itself remained a different design than the rest. This change happened in bug 1828413:

Last good revision: 1f216436fe2b858a7b7e9a22517e60ac222c40ed
First bad revision: df18ff71a63d4d18e7cf9d6d2a0b0f0662076264
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1f216436fe2b858a7b7e9a22517e60ac222c40ed&tochange=df18ff71a63d4d18e7cf9d6d2a0b0f0662076264

It is important to notice that before this change, the checkbox was even more different than the rest of them due to the different checkbox background color.

Further back, the even older design of this specific checkbox was changed in Nightly v51.0a1 between 2016-08-04 and 2016-08-05. Before this change, the design of the checkbox in high contrast looked best ( slim checkbox, black on white):

Got as far as we can go bisecting nightlies...
Last good revision: 1576e7bc1bec7232e9e4ba78cce62526b1a6380b (2016-08-04)
First bad revision: d320ef56876f52db9bc0eb79554c7332d4793769 (2016-08-05)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1576e7bc1bec7232e9e4ba78cce62526b1a6380b&tochange=d320ef56876f52db9bc0eb79554c7332d4793769

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1828413, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

That's the system design for checkboxes in the high contrast theme, see gtk3-demo which shows the same checkboxes.