1873196 - "browser.close" has to close all top-level browsing contexts by discarding any "beforeunload" handlers

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[alexrudenko]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Steps to reproduce:

Run the following script

import puppeteer from "puppeteer";

const browser = await puppeteer.launch({
  product: 'firefox',
  protocol: 'webDriverBiDi',
});

const page = await browser.newPage();

await page.goto('http://127.0.0.1:8080/test/assets/beforeunload.html');

await page.click('body');

await browser.connection.send('browser.close', {});

The content of beforeunload.html is

<div>beforeunload demo.</div>
<script>
window.addEventListener('beforeunload', event => {
  // Chrome way.
  event.returnValue = 'Leave?';
  // Firefox way.
  event.preventDefault();
});
</script>

Adjust the page URL according to the path on your server.

Actual results:

The browser is not closed. The page shows the dialog to confirm unload.

Expected results:

According to https://w3c.github.io/webdriver-bidi/#command-browser-close the implementation should "Close any top-level browsing contexts without prompting to unload."

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Right now we do not support beforeunload events and completely turn those off via the preference dom.disable_beforeunload. So maybe Puppeteer needs to set it on its own for the Firefox preferences for now.

Also before we can close top-level browsing contexts without prompting we need bug 1862380 fixed.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1873196 - [webdriver-bidi] Close all open tabs by skipping beforeunload prompts when running "browser.close" command.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1873196 - [wdspec] Add bidi-only test for "browser.close" with skipping beforeunload prompt.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/065a840047f6
[webdriver-bidi] Close all open tabs by skipping beforeunload prompts when running "browser.close" command. r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/94263d5ebf02
[wdspec] Add bidi-only test for "browser.close" with skipping beforeunload prompt. r=webdriver-reviewers,Sasha

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/065a840047f6
https://hg.mozilla.org/mozilla-central/rev/94263d5ebf02