1873394 - [wmfme] create telemetry probes to collect playback data for MFCDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

We want to add some probes to understand whether MFCDM is working well.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1873394 - part1 : collect playback statistic data for MFCDM.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1873394 - part2 : add telemetry probe to record error and crash.

Depends on D198109

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1873394 - part3 : record telemetry for the failure to recreate the state machine.

When enaling the media engine playback, we would always start with using
the external state machine. Then fallback to the normal state machine if
the conditions are not met, eg. only enable encrypted media playback, or
the codec types/key system types which the media engine doesn't support.

This kind of transistion should be smooth and always succeed. If not,
then it would probably cause bad effect on the user experience, so we
add the probes to measure the error rate.

Depends on D198110

Comment 4

[Alastor Wu [:alwu]]

Attachment: data-review-request

Comment 5

[Chris H-C :chutten]

Comment on attachment 9372191 [details]
data-review-request

PRELIMINARY NOTES:

For future reviews, please provide full information of what data is collected along with the events. In this case I read the code and the extra keys are a bunch of technical information like codecs and stuff that are no worse than Cat2.

(( Since I popped over to the code review and already suggested Glean, I feel I should also note here that Glean-defined data collections can use ./mach data-review to generate the data collection review request template for you. Just another little nicety that Glean's set up to provide. Oh, and if you choose to switch from Telemetry to Glean (or using Glean and GIFFT to collect to both Glean and Telemetry), there's no need for a new data collection review -- this one will suffice. You'll notice that there are no questions specific to the mechanism you're using to collect the data, so long as they're mozilla-controlled. ))

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Alastor Wu is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Alastor Wu [:alwu]]

Attachment: data-review-request

Update a new data review, because I changed the probe in my new patches.

Comment 7

[Chris H-C :chutten]

Comment on attachment 9378046 [details]
data-review-request

PRELIMINARY NOTES:
That's an interesting mix of ./mach data-review and plain template in your request.

The answer to Q6 should point to the Glean Dictionary, where all Glean data is documented in full.

The answer to Q8 should be "These collections are Glean. The opt-out can be found in the product's preferences."

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through the product's preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 130.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44fdf4e83c7c
part1 : collect playback statistic data for MFCDM. r=media-playback-reviewers,chunmin,chutten
https://hg.mozilla.org/integration/autoland/rev/6711b73d58e1
part2 : add telemetry probe to record error and crash. r=jolin,chutten
https://hg.mozilla.org/integration/autoland/rev/b355f33d28c9
part3 : record telemetry for the failure to recreate the state machine. r=jolin,chutten

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/44fdf4e83c7c
https://hg.mozilla.org/mozilla-central/rev/6711b73d58e1
https://hg.mozilla.org/mozilla-central/rev/b355f33d28c9

Comment 10

[pstanciu]

Backed out for causing bug 1879250
Backout link https://hg.mozilla.org/mozilla-central/rev/43f065b8fdeb618362374f49b893df0709008416

Comment 11

[Keith Cirkel]

Attachment: WIP: Backed out 3 changesets (Bug 1873394) for causing bug 1879250. CLOSED TREE

Backed out changeset b355f33d28c9 (bug 1873394)
Backed out changeset 6711b73d58e1 (bug 1873394)
Backed out changeset 44fdf4e83c7c (bug 1873394)

Comment 12

[Keith Cirkel]

Attachment: WIP: Backed out 3 changesets (Bug 1873394) for causing bug 1879250. CLOSED TREE

Backed out changeset b355f33d28c9 (bug 1873394)
Backed out changeset 6711b73d58e1 (bug 1873394)
Backed out changeset 44fdf4e83c7c (bug 1873394)

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbe965b583e3
part1 : collect playback statistic data for MFCDM. r=media-playback-reviewers,chunmin,chutten
https://hg.mozilla.org/integration/autoland/rev/a7fbe977109f
part2 : add telemetry probe to record error and crash. r=jolin,chutten
https://hg.mozilla.org/integration/autoland/rev/89318af79fc6
part3 : record telemetry for the failure to recreate the state machine. r=jolin,chutten

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/bbe965b583e3
https://hg.mozilla.org/mozilla-central/rev/a7fbe977109f
https://hg.mozilla.org/mozilla-central/rev/89318af79fc6