1873487 - In Offline mode - send unsent messages has no prompt to go online

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Anje]

Windows 10 OS

In 102* if Offline and you click on 'Sent unsent messages' you would get a pop up prompt which said: " You are currently offline. Do you want to go online to send unsent messages?"

This is not occurring in current release nor in beta 122.0b2 .

Process:

• In 'Offline' mode
• Click on 'Write'
• compose email
• click on 'Send Later'
• Email goes to 'Outbox' in 'Local Folders'
• Right click on 'Outbox'
• 'Send unsent messages' is enabled - so click on it.

Actual Result
Nothing occurs.
Email still in Outbox.
No pop up prompt.

Expected Result
A pop up prompt which says : " You are currently offline. Do you want to go online to send unsent messages?" with options 'OK' and 'Cancel'

Comment 1

[Wayne Mery (:wsmwk)]

Anje, https://mozilla.github.io/mozregression/ can be used to find the regression range

Comment 2

[betterbird.project+13]

It works via "File > Sent unsent messages", but not, as reported, via the context menu on the outbox. Error console:

Uncaught Error: Component returned failure code: 0x80550014 [nsIMsgSendLater.sendUnsentMessages]
    SendUnsentMessages chrome://messenger/content/mailWindowOverlay.js:1607
    onCommand chrome://messenger/content/about3Pane.js:642
    handleEvent chrome://messenger/content/about3Pane.js:285

0x80550014 is NS_MSG_ERROR_OFFLINE.

Looks like Supernova bustage, the new implementation isn't correct:
https://hg.mozilla.org/comm-central/rev/f1c1efa90b0f#l1.391
Instead of this:
https://searchfox.org/comm-esr115/rev/b21a2c8ee619566dc412c9ed3cc122ce9c0814b7/mail/base/content/about3Pane.js#642
it should likely be running this "goDoCommand('cmd_sendUnsentMsgs')" triggering this:
https://searchfox.org/comm-esr102/rev/e93a5d1c08d70a159a04d1b8cb1e31953889616c/mail/base/content/mail3PaneWindowCommands.js#911-917

Comment 3

[betterbird.project+13]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1873487-fix-send-unsent-outbox-context.patch

Comment 4

[Magnus Melin [:mkmelin]]

The Outbox context menu is working fine for me on daily.

Comment 5

[Magnus Melin [:mkmelin]]

Also fine on 115 (linux).

Comment 6

[betterbird.project+13]

The menu calls topChromeWindow.SendUnsentMessages(); which fails when offline. The 102 code called goDoCommand("cmd_sendUnsentMsgs"); which issued a prompt for going online first. Are we missing something?

Comment 7

[Magnus Melin [:mkmelin]]

Oh I see it now. I forgot to actually go offline...

Comment 8

[Magnus Melin [:mkmelin]]

Attachment: Bug 1873487 - Fix 'send unsent messages' on the Outbox context menu when in offline mode. r=#thunderbird-reviewers

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1873487-fix-send-unsent-outbox-context.patch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/14e4084a4467
Fix 'send unsent messages' on the Outbox context menu when in offline mode. r=aleca

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9372070 [details]
Bug 1873487 - Fix 'send unsent messages' on the Outbox context menu when in offline mode. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: in offline mode, outbox send unsent context menu not working
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9372070 [details]
Bug 1873487 - Fix 'send unsent messages' on the Outbox context menu when in offline mode. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 115.8.0:
https://hg.mozilla.org/releases/comm-esr115/rev/585cf63e9879