1873588 - Canvas demo (https://sketchtoy.com/66043688) doesnt draw anything after scrolling out of view

Status: RESOLVED DUPLICATE of bug 1872705

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Disable any adblocking/ tracking protection (Or use a new profile as we need some fb comments to load)
Go to https://sketchtoy.com/66043688
Drag teh slider all the way to the right
Scroll down on the page. Some fb comments will load
Click on "load more comments" button. Scroll further down
Now scroll up back to the demo

AR: Demo disappears and nothing is drawn on the screen (sometimes the demo will reappear after few seconds)
ER: Not so

Good : https://share.firefox.dev/48IJlI0 (terrible jank on scrolling up but atleast the demo is displayed)
Bad: https://share.firefox.dev/48p3CTn (no jank and no demo)

Regressed by :
Bug 1863914: Use multiple shmem buffers for remote canvas recording. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D193207

Bonus points for fixing the performance of the demo with D2d-canvas. (skia-canvas and gpu-canvas work great here)

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1863914

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Could you only reproduce this with D2D canvas?

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Also the "good" profile didn't symbolicate properly. Would you mind collecting it again? Thanks!

Comment 5

[Mayank Bansal]

(In reply to Andrew Osmond [:aosmond] (he/him) from comment #3)

Could you only reproduce this with D2D canvas?

Yes. skia-canvas and gpu-canvas dont repro this.

(In reply to Andrew Osmond [:aosmond] (he/him) from comment #4)

Also the "good" profile didn't symbolicate properly. Would you mind collecting it again? Thanks!

https://share.firefox.dev/48IJlI0 (WIll also update comment #0 with this profile)

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

Okay, great. So if I am understanding this correctly:

• After bug 1863914 landed, you see the jank.
• After bug 1871467 landed, you no longer see it render

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

I don't think we are in a position to uplift the remote texture to beta, plus whatever fix we have yet to prepare for the display in 123 nightly, so I'm not sure entirely what to do about 122 beta.

Comment 8

[Lee Salzman [:lsalzman]]

This seems like it is probably a dup of bug 1872705.

Comment 9

[Mayank Bansal]

(In reply to Andrew Osmond [:aosmond] (he/him) from comment #6)

Okay, great. So if I am understanding this correctly:

• After bug 1863914 landed, you see the jank.
• After bug 1871467 landed, you no longer see it render

Er no. My baseline to test was from Oct2023 (before teh shmem stuff landed). I saw jank there, and assumed the demo is janky.
After bug 1863914 , I see the rendering bug. I dont see anything specific with bug 1871467 (not sure where you got that from :) )

Comment 10

[Bob Owen (:bobowen)]

No comments appear for me, I've turned off tracking protection with a new profile, is there anything else I might need to do?

Comment 11

[Mayank Bansal]

(In reply to Bob Owen (:bobowen) from comment #10)

No comments appear for me, I've turned off tracking protection with a new profile, is there anything else I might need to do?

No idea. For me, just turning off ublock on my regular profile worked. Maybe try reducing the vertical height of the browser window and retrying?

Comment 12

[Bob Owen (:bobowen)]

(In reply to Mayank Bansal from comment #11)

(In reply to Bob Owen (:bobowen) from comment #10)

No comments appear for me, I've turned off tracking protection with a new profile, is there anything else I might need to do?

No idea. For me, just turning off ublock on my regular profile worked. Maybe try reducing the vertical height of the browser window and retrying?

OK, I think I can kind of reproduce by making the window very short.
It takes a while for the demo image to reappear, when I scroll back up.
My WIP patch on bug 1872705 does seem to help.
Would you mind trying one of the try builds with that, to see if it helps:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/JV0szVMkR6-g008Ewcrydg/runs/0/artifacts/public/build/install/sea/target.installer.exe

Comment 13

[Mayank Bansal]

(In reply to Bob Owen (:bobowen) from comment #12)

(In reply to Mayank Bansal from comment #11)

(In reply to Bob Owen (:bobowen) from comment #10)

No comments appear for me, I've turned off tracking protection with a new profile, is there anything else I might need to do?

No idea. For me, just turning off ublock on my regular profile worked. Maybe try reducing the vertical height of the browser window and retrying?

OK, I think I can kind of reproduce by making the window very short.
It takes a while for the demo image to reappear, when I scroll back up.
My WIP patch on bug 1872705 does seem to help.
Would you mind trying one of the try builds with that, to see if it helps:

I used the build from here : https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=JV0szVMkR6-g008Ewcrydg.0&revision=95568777446e24d0d875a6f2f20d3cbc95e78241 https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/JV0szVMkR6-g008Ewcrydg/runs/0/artifacts/public/build/target.zip

Profile: https://share.firefox.dev/3tKGOhK
It is certainly better. Now when i scroll up, the demo is drawn after about 1-2 second of delay.

Comment 14

[Mayank Bansal]

Attachment: bandicam 2024-01-09 23-41-17-279.mp4

Video for comment #13

Comment 15

[Bob Owen (:bobowen)]

Thanks

Comment 16

[Mayank Bansal]

Profile from the latest Nightly: https://share.firefox.dev/47pVArW

Comment 17

[Donal Meehan [:dmeehan]]

(In reply to Lee Salzman [:lsalzman] from comment #8)

This seems like it is probably a dup of bug 1872705.

:bobowen do you think it's safe to resolve this as a duplicate, or are you planning anything else here?

Comment 18

[Bob Owen (:bobowen)]

(In reply to Donal Meehan [:dmeehan] from comment #17)

(In reply to Lee Salzman [:lsalzman] from comment #8)

This seems like it is probably a dup of bug 1872705.

:bobowen do you think it's safe to resolve this as a duplicate, or are you planning anything else here?

I think we should defer to Mayank - do you still think there is a problem here?

Comment 19

[Mayank Bansal]

(In reply to Bob Owen (:bobowen) from comment #18)

(In reply to Donal Meehan [:dmeehan] from comment #17)

(In reply to Lee Salzman [:lsalzman] from comment #8)

This seems like it is probably a dup of bug 1872705.

:bobowen do you think it's safe to resolve this as a duplicate, or are you planning anything else here?

I think we should defer to Mayank - do you still think there is a problem here?

My original issue was a regression - "Subjectively nothing is drawn on the screen for eternity and that is very noticeable" . That is fixed. IMO, this bug can be duped.