1873600 - On Windows, Modified canvas demo stops running after a few seconds and system-level memory steadily increases

Status: RESOLVED DUPLICATE of bug 1872705

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Use latest Nightly on Windows (which should have d2d-canvas)
Open the attached demo

AR:

1. After a few seconds the demo stops running
2. The system-level memory rises quickly at a very steady state

ER : Not so

Regression range:

Bug 1871467 - Remove unnecessary CanvasTranslator locking. r=aosmond CLOSED TREE

Differential Revision: https://phabricator.services.mozilla.com/D197112

The modification i did was this :

	// The number of particles to generate
	Original -> i = 10000;
            Modified-> i = 100000;

For reference, original demo is at https://lab.hakim.se/sphere/. The obvious question is if this modified demo is a realistic use-case or not.

Comment 1

[Mayank Bansal]

Attachment: index.html

Comment 2

[Mayank Bansal]

Attachment: about:support

Comment 3

[Mayank Bansal]

The modified demo runs absolutely smooth with skia-canvas . With gpu-canvas, behaviour similar to d2d-canas is observed.

Comment 4

[Lee Salzman [:lsalzman]]

The regression range isn't very useful then if it affects gpu-canvas as well, as that means that the issue actually predates bug 1871467. The only thing it says is that it has some relation to transitioning to RemoteTextureMap usage, which both now use.

Comment 5

[Mayank Bansal]

(In reply to Lee Salzman [:lsalzman] from comment #4)

The regression range isn't very useful then if it affects gpu-canvas as well, as that means that the issue actually predates bug 1871467. The only thing it says is that it has some relation to transitioning to RemoteTextureMap usage, which both now use.

For doing the bisection, I focused on the rapid steady memory increase when the modified demo is opened. IOW, the modified demo didnt increase memory rapidly before the regressing bug.
Let me do a regressing range with gpu-canvas if that helps

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1871467

Comment 7

[Mayank Bansal]

With gpu-canvas enabled*, the regressing bug is :
Bug 1829026 - Handle KERN_ABORTED from semaphore_wait. r=aosmond

Differential Revision: https://phabricator.services.mozilla.com/D195952

Make what you will of this.

*gfx.direct2d.disabled = true
gfx.canvas.accelerated = true
gfx.canvas.remote.worker-threads = 0

Comment 8

[Mayank Bansal]

This is fixed for both d2d-canvas and gpu-canvas.

Bisection point to
Bug 1872705: Set a maximum number of recycled canvas buffers. r=gfx-reviewers,lsalzman

Differential Revision: https://phabricator.services.mozilla.com/D197856

Closing as dupe.