1873610 - Improve error message for import/export modules

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1872671#c5

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1873610 - Part 2: Improve modules import/export error messages.

Refactor the error message with the adding the information from the imported
module, for example:

// a.mjs
import { a } from "./b.mjs";

// b.mjs
const b = 1;

Originally the error message is "import not found: default", now it
becomes "The request module: b.mjs doesn't provide an export named: a"

// c.mjs
import { c } from "./d.mjs";

// d.mjs
export * from "./d1.mjs";
export * from "./d2.mjs";

// d1.mjs
export const c = 1;

// d2.mjs
export const c = 2;

Originally the error message is "ambiguous import: c", now it becomes
"The requested module d.mjs contains ambiguous star export: c from
d1.mjs and d2.mjs"

Add another error message for circular import:

// e.mjs
export { e } from "f.mjs";

// f.mjs
export { e } from "e.mjs";

Originally it was "indirect export not found: e", now it is
"The request module: f.mjs contains circular import: e".

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1873610 - Part 1: Add FilenameSlot and filename method in ModuleObject.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1873610 - Part 3: Pass ModuleErrorInfo to SyntheticModuleResolveExport.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1873610 - Part 1: Add ModuleObject::filename().

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/7e3d952f4a9a
Part 1: Add ModuleObject::filename(). r=jonco
https://hg.mozilla.org/mozilla-central/rev/f1c810bb6074
Part 2: Improve modules import/export error messages. r=jonco
https://hg.mozilla.org/mozilla-central/rev/10d3a32a9211
Part 3: Pass ModuleErrorInfo to SyntheticModuleResolveExport. r=jonco

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7e3d952f4a9a
https://hg.mozilla.org/mozilla-central/rev/f1c810bb6074
https://hg.mozilla.org/mozilla-central/rev/10d3a32a9211