1880464 - Modules sometimes don't have filenames

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jon Coppeard (:jonco)]

It would be helpful for error reporting if we could assume that all modules have a filename.

The filename comes from the script source associated with the script source object associated with the module's script. This is usually set from the CompileOptions supplied when compiling the script.

Adding an assert in ModuleObject::initScriptSlots shows that the filename is not always present.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1880464 - Ensure that all modules have a filename r?arai

Comment 2

[Jon Coppeard (:jonco)]

The above patch sets a default filename in the compile options in a couple of places in the shell where we create modules and then asserts that a filename is present during module initialisation.

This passes browser module tests but fails some shell tests:

    parser/compile-script.js
    parser/stencil-laziness-validate.js
    xdr/module-exports.js
    xdr/module-imports.js
    xdr/module-oom.js
    xdr/module.js

Looking at the parser/compile-script.js failure it seems that InstantiateModuleStencil has input containing the filename but this is not transferred to the module created by CompilationStencil::instantiateStencils.

arai would you know what's going on here?

Comment 3

[Tooru Fujisawa [:arai]]

The filename is set during compilation.

The JS::CompileOptions created inside InstantiateModuleStencil is used as JS::InstantiateOptions, which is very small subset of JS::CompileOptions.

If module needs filename, it should be set while compilation:

• CompileToStencil
• CompileToStencilXDR

OffThreadCompileModuleToStencil already sets the filename, so this doesn't need fix I think.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/213e2c05e438
Ensure that all modules have a filename r=arai

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/213e2c05e438