1873683 - Firefox view history card list items expands while minimized/maximized the browser with browser buttons

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: history-list-state-after-maximized.png

Found in

• Firefox 122.0b7

Affected versions

• Firefox 123.0a1 (2024.01.09)
• Firefox 122.0b7

Unaffected versions

• Firefox 120.0
• Firefox 121.0.1

Tested platforms

• Affected platforms: macOS 12, Ubuntu 22, Windows 10

Preconditions

• Firefox profile with history records

Steps to reproduce

1. Open Firefox View Next Tab and focus the History, History card is displayed and all items are sorted by date
2. Click on up arrow to hide list
3. Interact with browser maximize and minimize buttons, check the History card state.

Expected result

• History card lists state remains in the collapsed state while minimized and maximized the browser with browser buttons.

Actual result

• History card lists items expands while minimized and maximized the browser with browser buttons.

Regression range

• I will come back with regression range ASAP.

Additional notes

• Attached a screenshot with the issue.
• On Windows and Ubuntu the issue is reproducing only partially, when interacting with minimize button, clicking on maximize button the list remain in collapsible state.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:zstimi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=026fcf3ccef7d5ab4175021ea14ccda665206204&tochange=aaef3dd14fe910584d8ca0440a6bdf0ee36bfd22

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1859788

:kcochrane, since you are the author of the regressor, bug 1859788, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Kelly Cochrane [:kcochrane]]

It looks like this also happens when you collapse a history card, switch to another tab, and then switch back to the Firefox View tab.

Updated STR:

• Load Firefox View
• Navigate to the history page
• Collapse the first card (or any card really)
• Navigate away from the History page or Fx View entirely (change to another page in Fx View, switch to another tab, minimize the browser window, etc.)
• Navigate back to the History page, and ensure that the card(s) collapsed are still collapsed

Note that once Fx View is reloaded by a page refresh or browser reload, the card collapsed state within History will be reset and all cards will be expanded by default.

I imagine it's to do with this bit of code here that renders each card individually using the repeat Lit directive.

Comment 5

[Donal Meehan [:dmeehan]]

:kcochrane we are in the last week of beta for Fx122. 122.0b9 builds on 2024-01-12.
This has an S4 severity, though doesn't look like it was triaged by the Triage Owner.
Do you think you might have a fix in time, or is it likely to come later than the end of beta?

Comment 6

[Sarah Clements [:sclements]]

We'll prioritize a fix for this :dmeehan, but seeing as its a S4 we'll aim to get it into 123 rather than scramble to get this into late beta.

Comment 7

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1873683 - Ensure card collapsed state is preserved on the History page when the view is changed in Fx View

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35998227fc47
Ensure card collapsed state is preserved on the History page when the view is changed in Fx View r=fxview-reviewers,sclements

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/35998227fc47

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox122 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Reproduced on Firefox 123.0a1 (2024.01.09) on Windows 10.
I can confirm this issue is fixed, I verified using Firefox latest nightly 123.0a1 (from 2024.01.17) on Windows 10, Ubuntu 22 and macOS 12.