1859788 - Implement virtualizer in tab lists for improving performance in Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P1)

Description

[Kelly Cochrane [:kcochrane]]

Pages in Firefox View that can include long lists of tab data such as History and Open Tabs should make use of a virtualizer to only render items in smaller chunks in order to improve performance.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Does "Find in page" still work on the "Open Tabs" page with list virtualization?

Comment 4

[Kelly Cochrane [:kcochrane]]

Hi, Jeff! We've got virtual list work behind a pref for now as well as search functionality, and we're planning on turning those on at the same time to prevent issues with find in page. We'll likely need to re-map the find in page shortcut to move the cursor to the search input as it does in other browsers.

Comment 5

[Sarah Clements [:sclements]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)

Does "Find in page" still work on the "Open Tabs" page with list virtualization?

As Kelly said, we will be adding search on each section of view - we're planning to ship search plus the virtual list together (turning all prefs ON) in 122 (remapping of find in bug will likely be in 123). I mentioned the virtual list for your benefit due to the issues you've encountered with large amounts of open tabs, in the event you wanted to try it out sooner. If you rely on "Find in Page" then you might want to wait until the open tabs search in bug 1831142 lands in Nightly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3d999e4ff71
Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer

Comment 7

[Norisz Fay [:noriszfay]]

Backed out for causing firefoxview related failures

Backout link

Push with failures

Failure log 1 // Failure log 2

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1b32d718ed1
Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer

Comment 9

[Cosmin Sabou [:CosminS]]

Backed out for high frequency failures on browser_firefoxview_next_general_telemetry.js.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=e1b32d718ed12c6eb35ba4ac41e7f23895f6f082&tochange=ac99cb1291098db9161c56ba4e184dd55edb0fb2&test_paths=browser%2Fcomponents%2Ffirefoxview%2Ftests%2Fbrowser&selectedTaskRun=I9MKbMkeRjCPnQJ-8yHfyg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=438345608&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/71a7d5e0f25c3d0a742b64483f2e8719e97d6b39

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaef3dd14fe9
Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/aaef3dd14fe9