1873688 - Inappropriate "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction", and "script.disown"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Alexandra Borovova [:Sasha]]

In the initial implementation (see bug1779231), we assumed that specification of "script.evaluate", "script.callFunction", and "script.disown" (see this spec issue) should move into the direction of allowing to have only one type of argument based on the fields and added the assertion to not allow "context" and "realm" fields at the same time. But the spec was not changed that way, and now it causes an issue for a Puppeteer user: https://github.com/puppeteer/puppeteer/issues/11653, so in the scope of this bug we should align the implementation with the spec, meaning do not throw the error and ignore a "realm" argument if a "context" argument is provided.

Comment 1

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1873688 - [bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown".

Comment 2

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1873688 - [wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown".

Depends on D198151

Comment 3

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1873688 - [wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown".

Depends on D198152

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48568433ace2
[bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/56de1e8849a1
[wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/1cd3cffeda1b
[wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43923 for changes under testing/web-platform/tests

Comment 6

[Cristian Tuns]

Backed out for causing puppeteer failures in evaluation.spec.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | Evaluation specs Page.evaluate should work from-inside an exposed function (evaluation.spec.js) | expected FAIL

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0e34106490a
[bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/743d6c09f4d7
[wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/7a6e6415fd6b
[wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo

Comment 9

[Alexandra Borovova [:Sasha]]

The test expectation data for puppeteer is updated, so the failure should be gone now.

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d0e34106490a
https://hg.mozilla.org/mozilla-central/rev/743d6c09f4d7
https://hg.mozilla.org/mozilla-central/rev/7a6e6415fd6b

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot