Closed Bug 1873688 Opened 3 months ago Closed 3 months ago

Inappropriate "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction", and "script.disown"

Categories

(Remote Protocol :: WebDriver BiDi, defect, P2)

defect
Points:
2

Tracking

(firefox123 fixed)

RESOLVED FIXED
123 Branch
Tracking Status
firefox123 --- fixed

People

(Reporter: Sasha, Assigned: Sasha)

References

()

Details

(Whiteboard: [webdriver:m10][wptsync upstream][webdriver:relnote])

Attachments

(3 files)

In the initial implementation (see bug1779231), we assumed that specification of "script.evaluate", "script.callFunction", and "script.disown" (see this spec issue) should move into the direction of allowing to have only one type of argument based on the fields and added the assertion to not allow "context" and "realm" fields at the same time. But the spec was not changed that way, and now it causes an issue for a Puppeteer user: https://github.com/puppeteer/puppeteer/issues/11653, so in the scope of this bug we should align the implementation with the spec, meaning do not throw the error and ignore a "realm" argument if a "context" argument is provided.

Priority: -- → P1
Whiteboard: [webdriver:m10]
Severity: -- → S3
Type: task → defect
Priority: P1 → P2
Summary: Do not throw "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction", and "script.disown" → Inappropriate "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction", and "script.disown"
Assignee: nobody → aborovova
Status: NEW → ASSIGNED
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48568433ace2
[bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/56de1e8849a1
[wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/1cd3cffeda1b
[wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
Points: --- → 2
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43923 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m10] → [webdriver:m10], [wptsync upstream]

Backed out for causing puppeteer failures in evaluation.spec.js

Flags: needinfo?(aborovova)
Upstream PR was closed without merging
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0e34106490a
[bidi] Ignore "realm" argument when provided together with "context" to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/743d6c09f4d7
[wdpspec] Remove tests for "InvalidArgument" error when providing both "context" and "realm" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/7a6e6415fd6b
[wdpspec] Add tests for ignoring "realm" argument when provided together with "context" argument to "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo

The test expectation data for puppeteer is updated, so the failure should be gone now.

Flags: needinfo?(aborovova)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 123 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m10], [wptsync upstream] → [webdriver:m10][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: