1873833 - The buttons of the selection done by click/mouse drag do not show tooltips upon mouse hover

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Simona Badau, Desktop QA]

Found in

• Nightly 123.0a1

Affected versions

• Nightlu 123.0a1

Tested platforms

• Affected platforms: macOS 13, Ubuntu 22.04 and Windows 10 x64
• Unaffected platforms:

Preconditions

• 'screenshots.browser.component.enabled' is set to true in about:config

Steps to reproduce

1. Navigate to any website
2. Enable Screenshots by hitting the Cmd+Shift+S keys.
3. Mouse drag over the screenshots overlay.
4. Hover the mouse over the buttons of the created screenshot region: X, Copy, Download.

Expected result

• On mouse hover, the buttons should display tooltips: Cancel, Copy screenshot to clipboard and Download screenshot.

Actual result

• The buttons do not show tooltips upon mouse hover.

Regression range
This is not a regression, it's reproducible only when enabling the component version of Screenshots.

Additional notes

• Tooltips for buttons in the Save visible and Save full-screen dialogs are not affected; they are displayed on mouse hover.
• When setting 'screenshots.browser.component.enabled' to false, the issue is not reproducible.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sbadau, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Sam Foster [:sfoster] (he/him)]

Might be a regression, :niklas has offered to track it down.

Comment 3

[Niklas Baumgardner [:niklas]]

Hey :emilio, do you have any idea why the buttons in the anonymous content wouldn't show the tooltip/title when hovering?
The title attribute is set here and they are visible in the inspector but they never show when hovering.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1873833 - Make tooltips work on anonymous content / UA widgets. r=smaug

We also simplify the tooltip text provider loop, and make it work better
now that e.g. the anonymous button in file inputs can be targeted.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61e803f1a869
Make tooltips work on anonymous content / UA widgets. r=smaug,Gijs

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_delay_autoplay_silentAudioTrack_media

Backout link: https://hg.mozilla.org/integration/autoland/rev/cfac4625b82335e8f721640d8a0fc5308be0cd7d

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_delay_autoplay_silentAudioTrack_media.js | Test timed out -

Failure log ->TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_tooltip.xhtml | Test timed out

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef7936589928
Make tooltips work on anonymous content / UA widgets. r=smaug,Gijs

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ef7936589928

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Simona Badau, Desktop QA]

I can confirm that tooltips are now shown on Nightly 125.0a1 when hovering the mouse over the Cancel, Copy, and Download options in the Screenshots selection. However, I've noticed two behaviors that I'm not sure are intentional:

1. The tooltips are displayed only the first time the button is hovered over. Subsequent hovers do not show the tooltip again.

2. The tooltip text differs between the Copy and Download buttons displayed in the "Save visible" or "Save full page" dialogs. In these dialogs, "Copy screenshot to clipboard" and "Download screenshot" are displayed when hovering over the buttons, whereas in the selection's buttons, only "Copy" and "Download" are displayed.

Emilio or Sam, could you please confirm if the above behaviors are intended?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

(In reply to Simona Badau, Desktop QA from comment #11)

1. The tooltips are displayed only the first time the button is hovered over. Subsequent hovers do not show the tooltip again.

I cannot reproduce this (tested on Windows), can you file a separate bug with steps to reproduce it?

2. The tooltip text differs between the Copy and Download buttons displayed in the "Save visible" or "Save full page" dialogs. In these dialogs, "Copy screenshot to clipboard" and "Download screenshot" are displayed when hovering over the buttons, whereas in the selection's buttons, only "Copy" and "Download" are displayed.

This is probably unintentional, but unrelated to this, can you file a separate bug for it?

Thanks!

Comment 13

[Sam Foster [:sfoster] (he/him)]

(In reply to Simona Badau, Desktop QA from comment #11)

2. The tooltip text differs between the Copy and Download buttons displayed in the "Save visible" or "Save full page" dialogs. In these dialogs, "Copy screenshot to clipboard" and "Download screenshot" are displayed when hovering over the buttons, whereas in the selection's buttons, only "Copy" and "Download" are displayed.

Thanks for spotting this. I agree it would be good to get these aligned to say the same thing when they do the same thing. Can you file a separate bug for that?

Comment 14

[Simona Badau, Desktop QA]

Thanks Emilio and Sam! Logged Bug 1885512 and Bug 1885518 for the above mentioned issues.

Comment 15

[Simona Badau, Desktop QA]

Based on Comment 11 and on the fact that all the encountered new issues are already tracked in new bugs (Comment 14), I'm marking this as Verified.