1885512 - The tooltips of the selection's buttons are not redisplayed on subsequent hover

Status: NEW

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Simona Badau, Desktop QA, PTO 22-30June]

Attachment: Screenshot with the issue

Found in

• Nightly 125.0a1

Affected versions

• Nightly 125.0a1

Tested platforms

• Affected platforms: macOS 13, Ubuntu 22.4, Windows 10 x64

Steps to reproduce

1. Enable Screenshots and do a mouse click selection.
2. Hover the mouse subsequently over any of the buttons of the created screenshot region: X, Copy, Download.

Expected result

• On each mouse hover, the buttons should display tooltips: Cancel, Copy screenshot to clipboard and Download screenshot.

Actual result

• The tooltips are displayed only the first time the button is hovered over. Subsequent hovers of the same button do not show the tooltip again.
  If I hover the mouse over other buttons or outside the Screenshots overlay then the tooltip is displayed again. For more details, please see the attached screen recording.

Regression range

• Not a regression.

Comment 1

[Sam Foster [:sfoster] (he/him)]

We just got the tooltips showing up in bug 1873833. :emilio, do you have any idea what is going on here?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I cannot repro this on either macOS or Linux, what am I missing? Have you been able to repro this sam?

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Ah, nevermind, if you hover over another button then the problem is fixed. But sure, looks like a bug, will look.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

So the issue seems to be we never get a mouseout event here, so we never detect our mouse has gone out of the button...

Olli, you're familiar with this code, if you know off-hand, do you know why mousemove events arrive just fine but mouseout events don't? I guess the chrome event listeners would only see a mouse out of the anon subtree, which in this case is unfortunately the whole page?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I wonder if we should make the event propagate to chrome event handler here
https://searchfox.org/mozilla-central/rev/a06d5a8871b1796f2dbd588ab518eaa98507e018/dom/base/FragmentOrElement.cpp#829-832

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

That would be quite big change, and likely trigger some other issues though. Perhaps we could initially limit it to some particular cases?

Comment 7

[Sam Foster [:sfoster] (he/him)]

I'm moving this to the DOM UI Event/Focus component. Let me know or move it back if there is something we can do on the front-end to fix this for the Screenshots case specifically.

Comment 8

[Sam Foster [:sfoster] (he/him)]

I don't think we need to block shipping the new Screenshots implementation on this bug.