1873950 - Temporary directories left behind from composing with dragged attachments

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[yo]

When adding an attachment from another message, this is stored in the temp directory in a folder pid-NNNN.
The code registers the file itself for deletion here:
https://searchfox.org/comm-central/rev/d47e431b702099ec3bbfa8a8fffe0060d4823497/mail/components/compose/content/MsgComposeCommands.js#7977
but both files and directories are left when TB closes.

Comment 1

[betterbird.project+13]

Not so easy to fix since the M-C code only allows for the deletion of files, not directories:
https://searchfox.org/mozilla-central/rev/b1a029fadaaabb333d8139f9ec3924a20c0c941f/uriloader/exthandler/nsExternalHelperAppService.cpp#1127-1130

(Note that bug 1873952 is a duplicate of this bug.)

Comment 3

[betterbird.project+13]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1873950-delete-temp-pid-NNNN.patch

Comment 4

[Silvia Bonavista i Serrat]

Attachment: Bug 1873950 - Delete pid-NNNN directory for temporary files on exit. r=mkmelin

Bonus fix: Fix nsMsgCreateTempFile() so it cleans up after itself and remove second copy of the function.

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1873950-delete-temp-pid-NNNN.patch

Depends on D204154

Comment 5

[Silvia Bonavista i Serrat]

Attachment: Bug 1873950 - Delete pid-NNNN directory for temporary files on exit. r=mkmelin

Bonus fix: Fix nsMsgCreateTempFile() so it cleans up after itself and remove second copy of the function.

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1873950-delete-temp-pid-NNNN.patch

Depends on D204411

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/733d04a27176
Delete pid-NNNN directory for temporary files on exit. r=mkmelin