1873973 - nsStandardURL incorrectly escapes ^ in the path

Status: REOPENED

(Core :: Networking, defect, P3)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

The failing tests are:
Parsing: <wss://host/ !"$%&'()*+,-./:;<=>@[\]^_{|}~> without base`

For Firefox:
!EQ("wss://host/%20!%22$%&'()*+,-./:;%3C=%3E@[/]^_%60%7B|%7D~", "wss://host/%20!%22$%&'()*+,-./:;%3C=%3E@[/]%5E_%60%7B|%7D~")

Chrome result:
!EQ("wss://host/%20!%22$%&'()+,-./:;%3C=%3E@[/]^_%60%7B|%7D~", "wss://host/%20!%22$%&'()+,-./:;%3C=%3E@[/]%5E_%60%7B%7C%7D~")
(they are escaping both ^ and | )

Comment 2

[Sean Kim]

Attachment: Bug 1873973 - Fix nsStandardURL incorrectly escaped "^" in the path r?edgul,valentin

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Note that ^ is a separator in the origin serialization.

We need to make sure we don't break the ability to deserialize them:
https://searchfox.org/mozilla-central/rev/f60bb10a5fe6936f9e9f9e8a90d52c18a0ffd818/caps/tests/unit/test_site_origin.js#17

Assert.equal(prinicpal1.origin, "http://example.com^userContextId=11");

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25f376fb859f
Fix nsStandardURL incorrectly escaped "^" in the path r=necko-reviewers,valentin

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/25f376fb859f

Comment 6

[Geoff Lankow (:darktrojan)]

Is there a chance this broke something in the page loading code? I've been having problems with a test that loads a URL containing ^ in various places. Instead of loading in the docShell we somehow end up at the external protocol service. I've been assuming it's a problem in our (Thunderbird's) networking code, and it probably is, but I can't find anything. (Bug 1899673 comment 3.)

The url is of the form imap://user@localhost:39033/fetch%3EUID%3E^INBOX%3E1.

• imap://user@localhost:39033/fetch%3EUID%3E^INBOX%3E1 fails to load.
• imap://user@localhost:39033/fetch%3EUID%3E%5EINBOX%3E1 works.
• imap://user@localhost:39033/fetch%3EUID%3E!INBOX%3E1 works.
• imap://user@localhost:39033/fetch%3EUID%3E!INBOX%3E1?test^test (^ in query) works.
• imap://user@localhost:39033/fetch%3EUID%3E!INBOX%3E1&test^test (^ in path) fails.
• imap://user@localhost:39033/fetch%3EUID%3E!INBOX%3E1&test^ works.

Comment 7

[Valentin Gosu [:valentin] (he/him)]

I left a comment on 1899673 - I think the problem is how ImapURL uses the ^ character as a replacement for /.
Let me know if replacing ^ with { or another character that's not allowed in URL paths works

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing various regressions.
https://hg.mozilla.org/integration/autoland/rev/6828700ebc4deb1264dcc86935f108140e038c96

Comment 9

[Sean Kim]

Valentin, what are your thoughts on this bug?

Comment 10

[Valentin Gosu [:valentin] (he/him)]

Let's leave this in the backlog for now.
We might be able to fix it at some point in the future, but right now the effort needed might be too large for the payoff.