1874038 - Add Linux distro name and version to recorded system info

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Request Form

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1874038 - Derive LSB Release info from /etc/os-release.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1874038 - Add Linux distro name and version to recorded system info.

Comment 4

[Chris H-C :chutten]

Comment on attachment 9372107 [details]
Request Form

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Mike Hommey and Johan Lorenzo are responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 5

[BMO Github Automation]

Attachment: [mozilla-services/mozilla-pipeline-schemas] Bug 1874038 - Add environment.os.distro/distroVersion to table schemas (#799)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f03d067e5ce5
Derive LSB Release info from /etc/os-release. r=nika
https://hg.mozilla.org/integration/autoland/rev/661a07435d83
Add Linux distro name and version to recorded system info. r=chutten

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f03d067e5ce5
https://hg.mozilla.org/mozilla-central/rev/661a07435d83

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1874038 - Derive LSB Release info from /etc/os-release.

Original Revision: https://phabricator.services.mozilla.com/D198218

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1874038 - Add Linux distro name and version to recorded system info.

Original Revision: https://phabricator.services.mozilla.com/D198219

Comment 10

[Phabricator Automation]

Uplift Approval Request

• Risk associated with taking this patch: Low
• String changes made/needed: N/A
• Needs manual QE test: no
• Explanation of risk level: Straightforward addition of telemetry data.
• User impact if declined: This is meant to provide telemetry that will be useful for tracking the uptake of the deb packages, set to release in 122 (we can wait for 123, but if there's going to be another RC of 122 for bug 1874758, I'd rather ride along)
• Steps to reproduce for manual QE testing: N/A
• Is Android affected?: no
• Code covered by automated testing: no
• Fix verified in Nightly: yes

Comment 11

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• User impact if declined: This is meant to provide telemetry that will be useful for tracking the uptake of the deb packages, set to release in 122 (we can wait for 123, but if there's going to be another RC of 122 for bug 1874758, I'd rather ride along)
• Explanation of risk level: As far as nightly shows, the code works appropriately, and as far as I can tell, it's not broken in obvious ways, but I'd be fine leaving this one out and let it ride the train if you're not confortable with this assessment, at the cost of slightly less accurate telemetry for 122
• Steps to reproduce for manual QE testing: N/A
• Is Android affected?: no
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• String changes made/needed: N/A
• Risk associated with taking this patch: Low~Medium

Comment 12

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• User impact if declined: This is meant to provide telemetry that will be useful for tracking the uptake of the deb packages, set to release in 122 (we can wait for 123, but if there's going to be another RC of 122 for bug 1874758, I'd rather ride along)
• Explanation of risk level: As far as nightly shows, the code works appropriately, and as far as I can tell, it's not broken in obvious ways, but I'd be fine leaving this one out and let it ride the train if you're not confortable with this assessment, at the cost of slightly less accurate telemetry for 122 (that is, this is not strictly required to make the other patch in the bug work)
• Fix verified in Nightly: yes
• Is Android affected?: no
• Code covered by automated testing: no
• Steps to reproduce for manual QE testing: N/A
• String changes made/needed: N/A
• Risk associated with taking this patch: Low~Medium

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/804a3aab8289
https://hg.mozilla.org/releases/mozilla-release/rev/80027443d72a

Comment 14

[Mike Hommey [:glandium]]

Attachment: Bug 1874038 - Derive LSB Release info from /etc/os-release.

Original Revision: https://phabricator.services.mozilla.com/D198218

Comment 15

[Mike Hommey [:glandium]]

Attachment: Bug 1874038 - Add Linux distro name and version to recorded system info.

Original Revision: https://phabricator.services.mozilla.com/D198219

Comment 16

[Phabricator Automation]

Uplift Approval Request

• Needs manual QE test: no
• Explanation of risk level: This was shipped in 122 and doesn't affect anything directly visible to the user
• User impact if declined: The telemetry added here will be useful to establish a timeline for possibly phasing out binary support for older distros before next ESR
• Fix verified in Nightly: yes
• Is Android affected?: no
• Code covered by automated testing: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• String changes made/needed: N/A

Comment 17

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: N/A
• Risk associated with taking this patch: Low
• Needs manual QE test: no
• Explanation of risk level: This was shipped in 122 and doesn't affect anything directly visible to the user
• User impact if declined: The telemetry added here will be useful to establish a timeline for possibly phasing out binary support for older distros before next ESR
• Steps to reproduce for manual QE testing: N/A
• Code covered by automated testing: no
• Is Android affected?: no
• Fix verified in Nightly: yes

Comment 18

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/12f04e3f46bf

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/2088ec07acce