1894412 - distro/distroVersion are null on e.g. Arch linux

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1894412 - When reading /etc/os-release, fall back to BUILD_ID when VERSION_ID is not set.

Arch Linux doesn't come with a VERSION_ID at all, but it has a BUILD_ID.
Semantically, falling back to BUILD_ID when VERSION_ID is not present
would seem fair play:

Per https://www.freedesktop.org/software/systemd/man/latest/os-release.html:

BUILD_ID=
A string uniquely identifying the system image originally used as the
installation base. In most cases, VERSION_ID or IMAGE_ID+IMAGE_VERSION
are updated when the entire system image is replaced during an update.
BUILD_ID may be used in distributions where the original installation
image version is important: VERSION_ID would change during incremental
system updates, but BUILD_ID would not. This field is optional.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/252deaf48658
When reading /etc/os-release, fall back to BUILD_ID when VERSION_ID is not set. r=xpcom-reviewers,emilio

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/252deaf48658

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1894412 - When reading /etc/os-release, fall back to BUILD_ID when VERSION_ID is not set.

Arch Linux doesn't come with a VERSION_ID at all, but it has a BUILD_ID.
Semantically, falling back to BUILD_ID when VERSION_ID is not present
would seem fair play:

Per https://www.freedesktop.org/software/systemd/man/latest/os-release.html:

BUILD_ID=
A string uniquely identifying the system image originally used as the
installation base. In most cases, VERSION_ID or IMAGE_ID+IMAGE_VERSION
are updated when the entire system image is replaced during an update.
BUILD_ID may be used in distributions where the original installation
image version is important: VERSION_ID would change during incremental
system updates, but BUILD_ID would not. This field is optional.

Original Revision: https://phabricator.services.mozilla.com/D209089

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Missing telemetry for users on (mostly) Arch Linux
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: It's a straightforward fall back, that doesn't touch the cases that already worked.
• String changes made/needed: N/A
• Is Android affected?: no

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1894412 - When reading /etc/os-release, fall back to BUILD_ID when VERSION_ID is not set.

Arch Linux doesn't come with a VERSION_ID at all, but it has a BUILD_ID.
Semantically, falling back to BUILD_ID when VERSION_ID is not present
would seem fair play:

Per https://www.freedesktop.org/software/systemd/man/latest/os-release.html:

BUILD_ID=
A string uniquely identifying the system image originally used as the
installation base. In most cases, VERSION_ID or IMAGE_ID+IMAGE_VERSION
are updated when the entire system image is replaced during an update.
BUILD_ID may be used in distributions where the original installation
image version is important: VERSION_ID would change during incremental
system updates, but BUILD_ID would not. This field is optional.

Original Revision: https://phabricator.services.mozilla.com/D209089

Comment 7

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: Missing telemetry for users on (mostly) Arch Linux
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Low
• Explanation of risk level: It's a straightforward fall back, that doesn't touch the cases that already worked.
• String changes made/needed: N/A
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/b2e78e9f8dcc

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/10d47da900b7