1874118 - Do not drop trailing spaces from non-trailing opaque paths data: URL

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

<a>: Setting <data:space ?query#fragment>.search = '' Do not drop trailing spaces from non-trailing opaque paths
FAIL message: assert_equals: expected "data:space #fragment" but got "data:space#fragment"

Comment 2

[Sean Kim [:sekim]]

{
            "comment": "Do not drop trailing spaces from non-trailing opaque",
            "href": "data:space ?query#fragment",
            "new_value": "",
            "expected": {
                "href": "data:space #fragment",
                "search": ""
            }
}

Adding this under search in setters_tests.json (rust-url) somehow passes, could you elaborate more on the test it is failing? Thanks

Comment 3

[Valentin Gosu [:valentin] (he/him)]

rust-url isn't being used for data URLs.
We use simpleURI for that https://searchfox.org/mozilla-central/source/netwerk/protocol/data/nsDataHandler.cpp
And I think the weird thing was that it only happens for <a> elements, not for the URL object.
So this works:

u = new URL("data:space ?query#fragment")
u.search = "" 
u.href // "data:space #fragment" 

but this doesn't:

x = document.createElement("a");
x.href = "data:space ?query#fragment";
x.search = "";
x.href // "data:space#fragment"

It's unclear why these two behave differently.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Maybe because we call SetHrefAttribute after changing the query - and that somehow ends up stripping the space?

Comment 5

[Valentin Gosu [:valentin] (he/him)]

The difference is

u = new URL("data:space ?q")
u.href // "data:space ?q"

u = new URL("data:space #q")
u.href // "data:space#q"

The second one is wrong. I think nsSimpleURI is to blame.

u = Services.io.newURI("data:space #q"); (in the browser console, Ctrl-Shift-J)
u.spec

has the same issue.

Comment 6

[Sean Kim [:sekim]]

Attachment: Bug 1874118 - Fix handling of trailing characters in opaque paths in URL r?valentin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5573d35897e6
Fix handling of trailing characters in opaque paths in URL r=valentin,necko-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5573d35897e6