1874119 - Setting <non-spec:/>.pathname = '/.//p'

Status: NEW

(Core :: Networking, defect, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

This bug comes from rust-url not being able to handle this case.

https://github.com/servo/rust-url/blob/f447500049cbfe42203ff16026842e74f3fd99ac/url/tests/expected_failures.txt#L48-L50

Comment 1

[edgul]

STR:

let url = new URL("non-spec:/"); 
url.pathname = "/.//p" 
url

Results in:

URL { href: "non-spec://p", ... , pathname: "//p", ... }

Expected (rust-url):

"href": "non-spec:/.//p",
"pathname": "//p"

Comment 2

[Sean Kim [:sekim]]

https://jsdom.github.io/whatwg-url/#url=bm9uLXNwZWM6Ly4vL3A=&base=YWJvdXQ6Ymxhbms=

Comment 3

[Sean Kim [:sekim]]

Seems like the issue is due to https://github.com/servo/rust-url/blob/f447500049cbfe42203ff16026842e74f3fd99ac/url/src/parser.rs#L1384-1385, this is unable to recognize cases where "//" occurs across serialization and pathname

Comment 4

[Sean Kim [:sekim]]

fn test_nonspec() {
    let u1 = url::Url::parse("non-spec:/").unwrap();
    let url = Url::join(&u1, "/.//p").unwrap();
    println!("{}", url);
    ...
}

>> non-spec:/.//p

The current test that I implemented is incorrect; is there a way to assign url.pathname for experimentation?

Comment 5

[edgul]

Did you try adding a test to the setters_tests.json?

It looks like that file gets pulled in here and sets the pathname here.

Comment 6

[Sean Kim [:sekim]]

.

Comment 7

[Sean Kim [:sekim]]

(In reply to Ed Guloien [:edgul] from comment #5)

Did you try adding a test to the setters_tests.json?

It looks like that file gets pulled in here and sets the pathname here.

The test already seems to exist, I just can't seem to log the issues via cargo test or any of its variants.

Comment 8

[edgul]

Ah, by "log" I'm assuming you mean print to std::out. (Please correct me if I'm wrong)
I believe you are looking for cargo test -- --nocapture

Comment 9

[Sean Kim [:sekim]]

Resolved on rust-url

Comment 10

[Sean Kim [:sekim]]

Tracking regression on rust-url:

1. lib.rs:2910
2. lib.rs:2789
3. lib.rs:1023
4. quirks.rs:275
5. mozurl_set_pathname
6. setFilePath

The issue was reproducible with:

#[test]
fn testing() {
    let mut url = Url::parse("data:/.0.1").unwrap();
    assert!(!url.cannot_be_a_base());

    url.set_path(".0.1");
    assert_eq!(url.as_str(), "data:/.0.1");
}

assertion `left == right` failed
  left: "dat/.0.1"
 right: "data:/.0.1"

Comment 11

[Sean Kim [:sekim]]

Patch is available on GitHub.