1874235 - Windows Error Reporting can fail in several ways

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

While analyzing the WER interceptor we found several issues that prevent it from working correctly:

• The logic parsing the command-line arguments for child process crashes stopped working, this is likely a regression which we didn't catch because there's no way to automatically test this (yet)
• Main process crashes might not be generated if the Crash Reports/pending folder doesn't exist (this mostly happens with local builds)
• Main process crashes might not be generated if the InstallTime<buildid> file is not present

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1874235 - Make the WER interceptor more robust r=yjuglaret

• Always provide a value for the installation time, even when we fail to read it from the corresponding file
• Parse the parent PID correctly
• Create the pending folder if it's missing

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gsvelto, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbd46c7fb4d1
Make the WER interceptor more robust r=yjuglaret

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fbd46c7fb4d1

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9373044 [details]
Bug 1874235 - Make the WER interceptor more robust r=yjuglaret

Beta/Release Uplift Approval Request

• User impact if declined: N/A
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: N/A
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed: None
• Is Android affected?: No

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9373044 [details]
Bug 1874235 - Make the WER interceptor more robust r=yjuglaret

Approved for 124.0b4

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d81a935e4bb3

Comment 8

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1874235 - Make the WER interceptor more robust

• Always provide a value for the installation time, even when we fail to read it from the corresponding file
• Parse the parent PID correctly
• Create the pending folder if it's missing

Original Revision: https://phabricator.services.mozilla.com/D198699

Comment 9

[Gabriele Svelto [:gsvelto]]

Comment on attachment 9387834 [details]
Bug 1874235 - Make the WER interceptor more robust

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Required for the uplift of bug 1872920
• User impact if declined: See bug 1872920
• Fix Landed on Version: 125
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch affects code that only runs after Firefox crashed, the risk of regression is minimal

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/806f87437f00