Closed Bug 1874290 Opened 3 months ago Closed 3 months ago

Add exceptions from a11y_checks for clicks on non-interactive toolbarsprings in Search and Address Bar tests

Categories

(Firefox :: Address Bar, task, P3)

task

Tracking

()

RESOLVED FIXED
124 Branch
Tracking Status
firefox124 --- fixed

People

(Reporter: ayeddi, Assigned: ayeddi)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

It appears that browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js and browser/components/urlbar/tests/browser/browser_closePanelOnClick.js tests send a click event on a non-interactive <toolbarspring> element to test that the URL Bar panel and a search tip would, in fact, be closed.

For users of keyboards and assistive technology another way like pressing Esc key is available to dismiss the dialog, thus we need to add an exception from the a11y_checks for this tests via setEnv and remove the fail-if notation from its test manifest.

a11y_checks failing data:

Path	Error	El ID	El tagName	El className
browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js	Node is not accessible via accessibility API	customizableui-special-spring1	toolbarspring	chromeclass-toolbar-additional
browser/components/urlbar/tests/browser/browser_closePanelOnClick.js	Node is not accessible via accessibility API	customizableui-special-spring1	toolbarspring	chromeclass-toolbar-additional

The browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js and browser/components/urlbar/tests/browser/browser_closePanelOnClick.js tests send a click event on a non-interactive <toolbarspring> element to test that the URL Bar panel and a search tip would, in fact, be closed.

For users of keyboards and assistive technology another way like pressing Esc key is available to dismiss the dialog, thus we need to add an exception from the a11y_checks for this tests via setEnv and remove the fail-if notations from their test manifests.

Assignee: nobody → ayeddi
Status: NEW → ASSIGNED
Pushed by ayeddi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/623f9d84907c
Add exceptions from a11y_checks for clicks on non-interactive chrome UI in Search and Address Bar. r=adw
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: