1874290 - Add exceptions from a11y_checks for clicks on non-interactive toolbarsprings in Search and Address Bar tests

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Anna Yeddi [:ayeddi]]

It appears that browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js and browser/components/urlbar/tests/browser/browser_closePanelOnClick.js tests send a click event on a non-interactive <toolbarspring> element to test that the URL Bar panel and a search tip would, in fact, be closed.

For users of keyboards and assistive technology another way like pressing Esc key is available to dismiss the dialog, thus we need to add an exception from the a11y_checks for this tests via setEnv and remove the fail-if notation from its test manifest.

a11y_checks failing data:

Path	Error	El ID	El tagName	El className
browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js	Node is not accessible via accessibility API	customizableui-special-spring1	toolbarspring	chromeclass-toolbar-additional
browser/components/urlbar/tests/browser/browser_closePanelOnClick.js	Node is not accessible via accessibility API	customizableui-special-spring1	toolbarspring	chromeclass-toolbar-additional

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1874290 - Add exceptions from a11y_checks for clicks on non-interactive chrome UI in Search and Address Bar. r=adw!

The browser/components/urlbar/tests/browser-tips/browser_searchTips_interaction.js and browser/components/urlbar/tests/browser/browser_closePanelOnClick.js tests send a click event on a non-interactive <toolbarspring> element to test that the URL Bar panel and a search tip would, in fact, be closed.

For users of keyboards and assistive technology another way like pressing Esc key is available to dismiss the dialog, thus we need to add an exception from the a11y_checks for this tests via setEnv and remove the fail-if notations from their test manifests.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/623f9d84907c
Add exceptions from a11y_checks for clicks on non-interactive chrome UI in Search and Address Bar. r=adw

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/623f9d84907c